fix(release): keep the release drafted until every platform has uploaded - #20
Merged
Conversation
softprops/action-gh-release defaults `draft` to false and updates the release it targets rather than only adding files to it. So the first platform to finish undid the draft-hold set two jobs earlier, and every platform after it uploaded into a release that was already at /releases/latest. v0.3.1 went out exactly that way: published carrying Linux and macOS while the Windows build was still compiling. For that window Colony offered an update that Windows users could not install — which is the harm the draft-hold exists to prevent, and it was being undone by the very next job. The canonical template in Project-Colony-Resources already passes `draft: true` here. Grape's copy predates that and had drifted; the rest of the drift is Grape's own — its release-please config-file, the ALSA build deps and a newer rust-cache pin — and stays. `publish` remains what makes a release visible, after it has verified every asset and signature is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
softprops/action-gh-releasedefaultsdraftto false, and it updates the release it targets rather than only adding files to it. So the first platform to finish undoes the draft-hold set two jobs earlier, and every platform after it uploads into a release that is already at/releases/latest.v0.3.1 went out exactly that way: published carrying Linux and macOS while the Windows build was still compiling. For that window Colony offered an update that Windows users could not install — which is precisely the harm the draft-hold exists to prevent, undone by the very next job.
This is separate from #18. That one fixed
ghdying without-R, which is why v0.3.0 had no assets. This one is why v0.3.1 was visible before it was complete. Both had to be wrong for the release path to look like it worked.The canonical template in Project-Colony-Resources already passes
draft: truehere — Grape's copy predates that and had drifted. The rest of the drift is Grape's own and stays: the release-pleaseconfig-file/manifest-file, the ALSA build dependencies, and a newerrust-cachepin.publishremains what makes a release visible, after it has verified every asset and signature is present.Still worth doing separately: Grape has no
workflow_dispatch, so a release that fails after its tag exists cannot be finished — v0.3.0 is stuck empty for that reason. The template now carries that recovery path (Resources#4); adopting it here is a larger change than this one-line fix and deserves its own review.