Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Nov 12, 2021

Fixes #3292 .

Description

This PR added support for no matching keys in all the MONAI dict transforms when allow_missing_keys is True.
I checked all the dict level transforms for the case that allow_missing_keys is True and no matching key in the input data.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 12, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli November 12, 2021 07:40
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 12, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 12, 2021

/build

@Nic-Ma Nic-Ma requested a review from wyli November 12, 2021 11:37
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 12, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 12, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 15, 2021

CI test error depends on: #3337.

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 16, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 16, 2021

/build

@Nic-Ma Nic-Ma requested a review from wyli November 16, 2021 00:18
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 16, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 16, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 16, 2021

/build

@Nic-Ma Nic-Ma requested a review from wyli November 16, 2021 15:44
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit b7daf80 into Project-MONAI:dev Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RandAffined fails with KeyError when allow_missing_keys and key at index 0 is missing

2 participants