3335 Fix hash verification of Clang #3337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
force-pushed
the
3335-fix-clang-test
branch
from
5f57ce5 to
ca21c6d
Compare
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
7 tasks
Contributor
Author
|
/build |
Contributor
|
Hi @Nic-Ma, this has been updated to use sha256 in the pytorch repo https://github.com/pytorch/pytorch/blob/1adeeabdc0c8832420c091c5c668843768530d7f/tools/linter/adapters/clangtidy_init.py#L128 I recommend we use #3340. |
Contributor
Author
|
Hi @wyli , OK, looks good to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3335 .
Description
This PR fixed the hash verification of Clang format package, I think they updated the binary file in Amazon S3.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.