Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Mar 11, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3921

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@ericspod
Copy link
Member

Time to drop support for Pytorch 1.6.0 and 1.7.1?

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks right to me, just to remove torch111 from the tested branched before making it a full PR.

wyli and others added 4 commits March 11, 2022 12:45
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Mar 11, 2022

/build

@wyli wyli marked this pull request as ready for review March 11, 2022 18:02
@wyli wyli enabled auto-merge (squash) March 11, 2022 19:07
@wyli wyli merged commit 4c2899a into dev Mar 11, 2022
@wyli wyli deleted the torch111 branch March 11, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compatibility test with torch 1.11

3 participants