-
Notifications
You must be signed in to change notification settings - Fork 1.4k
4037 Update base PyTorch docker to 22.03 #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/integration-test |
|
/black |
|
/build |
Hi Nic, just a reminder that this won't trigger integration tests with the new docker on your fork (because of the security settings). Normally I push to the core codebase (instead of to a fork) and do some temp tests then revert them. Please see the commit branch and history of this PR for an example. https://github.com/Project-MONAI/MONAI/pull/3297/commits cc @yiheng-wang-nv |
|
We do similar ci/cd regularly for adding/revising tests when newer pytorch is available, an example PR would be this one here #3926 in case @yiheng-wang-nv or other contributors would help with the upgrade in the future. |
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
premerge tests work fine, but in the future, would be good to have temporary tests to verify the integration tests
|
Hi @wyli , Thanks for your detailed instruction. Thanks. |
|
All the integration tests passed locally on V100 GPU. Thanks. |
Hi Nic, I didn't make it clear, |
Fixes #4037 .
Description
This PR updated the base PyTorch docker to 22.03 for docker and CI tests:
https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pytorch
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.