Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 1, 2022

Fixes #4037 .

Description

This PR updated the base PyTorch docker to 22.03 for docker and CI tests:
https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pytorch

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 1, 2022

/integration-test

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 1, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 1, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 1, 2022 04:41
@wyli
Copy link
Contributor

wyli commented Apr 1, 2022

/integration-test

Hi Nic, just a reminder that this won't trigger integration tests with the new docker on your fork (because of the security settings). Normally I push to the core codebase (instead of to a fork) and do some temp tests then revert them. Please see the commit branch and history of this PR for an example. https://github.com/Project-MONAI/MONAI/pull/3297/commits cc @yiheng-wang-nv

@wyli
Copy link
Contributor

wyli commented Apr 1, 2022

We do similar ci/cd regularly for adding/revising tests when newer pytorch is available, an example PR would be this one here #3926 in case @yiheng-wang-nv or other contributors would help with the upgrade in the future.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premerge tests work fine, but in the future, would be good to have temporary tests to verify the integration tests

@wyli wyli merged commit 4526b68 into Project-MONAI:dev Apr 1, 2022
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 1, 2022

Hi @wyli ,

Thanks for your detailed instruction.
As @yiheng-wang-nv and I have local environments, I think we can run it locally to verify with V100.
Now I am running all the integration tests locally, will update later when it's finished.
And BTW, if /integration-test can't work for fork repo, should we disable it to avoid misleading message?

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 1, 2022

All the integration tests passed locally on V100 GPU.

Thanks.

@wyli
Copy link
Contributor

wyli commented Apr 1, 2022

Hi @wyli ,

Thanks for your detailed instruction. As @yiheng-wang-nv and I have local environments, I think we can run it locally to verify with V100. Now I am running all the integration tests locally, will update later when it's finished. And BTW, if /integration-test can't work for fork repo, should we disable it to avoid misleading message?

Thanks.

Hi Nic, I didn't make it clear, /integration-test works fine, it's just we can't modify the integration config and at the same time trigger it from a fork. Local test is also good, but I'd prefer results on the ci server.

@wyli wyli mentioned this pull request Apr 1, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docker and CI tests to PyTorch 22.03

2 participants