Skip to content

Conversation

@bhashemian
Copy link
Member

@bhashemian bhashemian commented May 23, 2022

Fixes #637

Description

This PR updates Multiple Instance Learning Pipeline with the new components in MONAI.

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

bhashemian added 13 commits May 23, 2022 14:59
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian marked this pull request as ready for review May 27, 2022 14:37
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
bhashemian and others added 4 commits June 2, 2022 00:02
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian requested a review from Nic-Ma June 6, 2022 12:16
@bhashemian
Copy link
Member Author

@Nic-Ma Here is the accuracy metric of the updated pipeline with respect to the original one that Andriy has run the experiment and produced the figures. The dark blue is the original one and the orange is the updated one (ignore the other colors). Both dark blue and orange ones are performing very similarly considering the different randomness that they have.
Screen Shot 2022-06-02 at 11 05 51 AM

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian enabled auto-merge (squash) July 7, 2022 17:33
@bhashemian
Copy link
Member Author

@Nic-Ma I believe this pipeline is already tested by @myron and equivalent performance is reported. Can you please help to merge it?

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian requested a review from Nic-Ma July 8, 2022 15:55
@Nic-Ma Nic-Ma disabled auto-merge July 18, 2022 07:33
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.
@wyli Do you have any other comments?

Thanks.

@Nic-Ma Nic-Ma merged commit 0dc8cae into Project-MONAI:main Jul 20, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* Update mil pipeline

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Fix a typo

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Tiffile to cucim

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update to RandGridPatchd

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Fix import

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Add sort_key

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* sort key max to min

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Fix patch_size

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Stack patch locations

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Remove location

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Change to fix_num_patches

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update grid patch

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Add threshold_filter

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update threshold and add pad_mode=None

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update mil pipeline with new grid patch

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update GridPatch args

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update LabelEncodeIntegerGraded and sort imports

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nic Ma <nma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MONAI Pathology] Update multiple instance learning pipeline

2 participants