chore: cargo fmt + clippy -D warnings clean + regenerate Cargo.lock

[Fieldnote-Echo]

Foundational hygiene — merge first

Brings the extracted crate up to a strict lint gate (including the cross-platform matrix) so the three workstream PRs build on a clean base. No behavior change.

Changes

• cargo fmt --all across src/, tests/, examples/.
• cargo clippy --all-targets --all-features -- -D warnings clean (26 lints):
  • Mechanical rewrites: manual_is_multiple_of (13×, x % n == 0 → is_multiple_of, stable since 1.87 ≤ MSRV 1.89), manual_range_contains (2×), manual_repeat_n (1×, test).
  • #[allow] with justification: too_many_arguments (7× — SIMD kernels + bench fns whose arity is intrinsic) and needless_range_loop (7× — kernel loops doing raw pointer arithmetic / multi-array indexing). Only 2 trivial single-array test loops were converted to iterators.
• Cross-platform build fix: the x86 SIMD glue (SimdTier::Avx2/Avx512, BATCHED_AVX512_CHUNK, the simd_tier / centre_drop_used bindings) was defined unconditionally but referenced only by cfg(target_arch="x86_64") dispatch → dead/unused on aarch64, failing -D warnings (caught by macos-latest). Gated each with cfg_attr(not(x86_64), allow(...)) so the crate builds clean on ARM (scalar path); x86 untouched.
• Regenerate Cargo.lock (was version 3 with stale serde; now version 4, serde gone).

Verification

• cargo fmt --all --check + clippy --all-targets --all-features -- -D warnings — clean
• cargo test 80/0; --features experimental 86/0; RUSTFLAGS="-D warnings" cargo test 80/0 (rustc-warning-clean)
• cargo +1.89.0 build (MSRV) + cargo build --locked — pass
• aarch64 cross-build (lib + tests + examples, -D warnings) — clean; CI macos-latest (aarch64) green

No tests deleted or skipped.

[qodo-code-review]

Review Summary by Qodo

Apply cargo fmt and fix 26 clippy lints; regenerate Cargo.lock

✨ Enhancement

Walkthroughs

Description

• Applied cargo fmt across all source, test, and example files
• Fixed 26 clippy lints via mechanical rewrites and justified #[allow] attributes
  - manual_is_multiple_of (13×): replaced x % n == 0 with x.is_multiple_of(n)
  - manual_range_contains (2×): replaced negated range comparisons with !(a..=b).contains(&x)
  - manual_repeat_n (1×): replaced repeat(v).take(n) with repeat_n(v, n)
  - too_many_arguments (7×): added #[allow] on kernel functions with intrinsic arity
  - needless_range_loop (9×): added #[allow] on SIMD kernel loops and raw pointer arithmetic
• Regenerated Cargo.lock from version 3 to version 4, removing stale serde dependency

Diagram

flowchart LR
  A["Source/Test/Example Files"] -->|cargo fmt| B["Formatted Code"]
  B -->|clippy fixes| C["Lint-Clean Code"]
  C -->|manual rewrites| D["is_multiple_of, range_contains, repeat_n"]
  C -->|justified allows| E["SIMD kernels, too_many_arguments"]
  F["Cargo.lock v3"] -->|regenerate| G["Cargo.lock v4"]
  G -->|remove stale| H["No serde dependency"]

Loading

File Changes

1. examples/bench_rank.rs Formatting +141/-63

Format and add clippy allow attributes

examples/bench_rank.rs

---

2. src/rank.rs Formatting +15/-8

Add needless_range_loop allow and format assertions

src/rank.rs

---

3. src/rank_index/bitmap.rs ✨ Enhancement +19/-29

Replace modulo with is_multiple_of, add allow attributes

src/rank_index/bitmap.rs

---

View more (17)

4. src/rank_index/fastscan.rs Formatting +10/-19

Add too_many_arguments allow and format macro calls

src/rank_index/fastscan.rs

---

5. src/rank_index/index.rs Formatting +5/-1

Format struct initialization

src/rank_index/index.rs

---

6. src/rank_index/multi_bucket.rs Formatting +3/-6

Format iterator chain

src/rank_index/multi_bucket.rs

---

7. src/rank_index/quant.rs ✨ Enhancement +30/-15

Replace modulo with is_multiple_of, format function calls

src/rank_index/quant.rs

---

8. src/rank_index/quant_kernels.rs Formatting +13/-8

Add too_many_arguments allow and format assertions

src/rank_index/quant_kernels.rs

---

9. src/rank_index/util.rs Formatting +2/-7

Format conditional expression and function signature

src/rank_index/util.rs

---

10. src/rank_io.rs ✨ Enhancement +11/-21

Replace modulo checks with is_multiple_of and range contains

src/rank_io.rs

---

11. src/sign_bitmap.rs ✨ Enhancement +10/-11

Replace modulo with is_multiple_of, add allow attributes

src/sign_bitmap.rs

---

12. tests/rank_index/bitmap.rs Formatting +40/-23

Reorder imports and format assertions

tests/rank_index/bitmap.rs

---

13. tests/rank_index/fastscan.rs Formatting +15/-7

Reorder imports and format iterator chains

tests/rank_index/fastscan.rs

---

14. tests/rank_index/index.rs Formatting +3/-1

Reorder imports and add allow attributes

tests/rank_index/index.rs

---

15. tests/rank_index/main.rs ✨ Enhancement +14/-11

Reorder imports and replace repeat with repeat_n

tests/rank_index/main.rs

---

16. tests/rank_index/multi_bucket.rs Formatting +2/-2

Reorder imports

tests/rank_index/multi_bucket.rs

---

17. tests/rank_index/quant.rs ✨ Enhancement +17/-14

Reorder imports and refactor loop to iterator

tests/rank_index/quant.rs

---

18. tests/redteam_alpha.rs Formatting +21/-6

Format iterator chains and map expressions

tests/redteam_alpha.rs

---

19. tests/redteam_beta.rs Formatting +11/-29

Format filter chains

tests/redteam_beta.rs

---

20. tests/redteam_delta.rs Formatting +7/-5

Format file path construction

tests/redteam_delta.rs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

[gemini-code-assist]

Code Review

This pull request primarily focuses on code formatting, dependency cleanup, and minor refactoring for idiomatic improvements and lint compliance. Key changes include updating Cargo.lock to version 4, removing serde and its related sub-crates, and applying extensive formatting across the codebase, such as reordering imports and breaking long function signatures into multiple lines. The PR also introduces several clippy allow attributes for intentional manual indexing and high-arity functions, replaces manual modulo checks with is_multiple_of, and refactors various test loops and assertions for better readability. I have no feedback to provide as no review comments were submitted.