ci: test full backend workspace - #690
Merged
Merged
Conversation
milindsrivastava1997
force-pushed
the
ci/full-workspace-gate
branch
from
September 12, 2026 13:52
fd6c2fb to
73690b2
Compare
zzylol
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend CI must exercise data-plane runtime and process tests as well as control-plane tests.
Why: CI relied on sibling path checkouts for Collector and Sketchlib, so its dependency source could diverge from Cargo’s resolution.
What: Resolve
asap-precompute-rsandasap_sketchlibfrom their Gitmainbranches, with Cargo patching Collector’s internal Sketchlib path to the shared Git source. Remove the now-unused sibling dependency checkouts from CI.Before this PR: CI cloned sibling repositories while Cargo consumed local paths; dependency provenance depended on runner layout.
After this PR: Cargo.lock records the resolved Collector and Sketchlib commits, and CI builds directly from the same Git sources without sibling repository checkouts.
Verification:
cargo fmt -p control_plane -p data_plane -p asap_types -p asap_otel_proto -- --checkandcargo clippy --workspace --all-targets -- -D warningspass locally.Limitations: Dependencies follow
main; Cargo.lock pins the revisions selected for a given build, but an explicit dependency update can advance them. Visual evidence is not applicable.Collector integration scope: The two cross-repository tests
erp_measured_kll_collector_to_query_oracleandproduction_control_plane_to_data_plane_otlp_to_promqlare explicitly ignored until Collector supports the backend's current CollectorPlan schema (summary_catalog,pane_origin_ms, and window layout fields). Their original assertions remain intact and can be run with-- --ignored. The default workspace gate does not establish Collector compatibility. All other backend tests remain enabled. No Collector repository or production API changes are included in this adjustment.Collector-skip validation: On commit
19fb4ad5, backend formatting passes and the two affected integration targets finish with 12 passed, 0 failed, and 2 explicitly ignored. This is focused validation, not a claim that the latest full GitHub workflow is green.