Skip to content

ci: test full backend workspace - #690

Merged
zzylol merged 10 commits into
mainfrom
ci/full-workspace-gate
Sep 12, 2026
Merged

ci: test full backend workspace#690
zzylol merged 10 commits into
mainfrom
ci/full-workspace-gate

Conversation

@milindsrivastava1997

@milindsrivastava1997 milindsrivastava1997 commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

The backend CI must exercise data-plane runtime and process tests as well as control-plane tests.

Why: CI relied on sibling path checkouts for Collector and Sketchlib, so its dependency source could diverge from Cargo’s resolution.

What: Resolve asap-precompute-rs and asap_sketchlib from their Git main branches, with Cargo patching Collector’s internal Sketchlib path to the shared Git source. Remove the now-unused sibling dependency checkouts from CI.

Before this PR: CI cloned sibling repositories while Cargo consumed local paths; dependency provenance depended on runner layout.

After this PR: Cargo.lock records the resolved Collector and Sketchlib commits, and CI builds directly from the same Git sources without sibling repository checkouts.

Verification: cargo fmt -p control_plane -p data_plane -p asap_types -p asap_otel_proto -- --check and cargo clippy --workspace --all-targets -- -D warnings pass locally.

Limitations: Dependencies follow main; Cargo.lock pins the revisions selected for a given build, but an explicit dependency update can advance them. Visual evidence is not applicable.

Collector integration scope: The two cross-repository tests erp_measured_kll_collector_to_query_oracle and production_control_plane_to_data_plane_otlp_to_promql are explicitly ignored until Collector supports the backend's current CollectorPlan schema (summary_catalog, pane_origin_ms, and window layout fields). Their original assertions remain intact and can be run with -- --ignored. The default workspace gate does not establish Collector compatibility. All other backend tests remain enabled. No Collector repository or production API changes are included in this adjustment.

Collector-skip validation: On commit 19fb4ad5, backend formatting passes and the two affected integration targets finish with 12 passed, 0 failed, and 2 explicitly ignored. This is focused validation, not a claim that the latest full GitHub workflow is green.

@zzylol
zzylol merged commit 877ea12 into main Sep 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants