fix(precompute): correct counter resets in rate and increase - #657
Merged
Conversation
Contributor
Author
|
Compared against #492 (older PR fixing the same issue, #476): both use the same reset-detection/correction algorithm and equivalent merge semantics. The one functional gap here is Prometheus boundary extrapolation ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate()/increase()counter-reset handling for single and keyed accumulators.INC6binary format.asap-summary-ingestArroyo templates out of scope.Cutover
This PR intentionally breaks compatibility with existing increase-accumulator JSON and binary payloads. Existing precomputes must be discarded or regenerated before deploying the new format. The active Arroyo adapter also requires the current reset-aware fields.
Validation
cargo test -p query_engine_rust— 582 tests passed.cargo clippy -p query_engine_rust --lib --tests -- -D warningspassed.Fixes #476