This repository was archived by the owner on Mar 25, 2022. It is now read-only.
Add application pre-launches to boot loader#4
Merged
alicerunsonfedora merged 4 commits intoprospect-park-db2from Sep 11, 2019
Merged
Add application pre-launches to boot loader#4alicerunsonfedora merged 4 commits intoprospect-park-db2from
alicerunsonfedora merged 4 commits intoprospect-park-db2from
Conversation
… tasks on boot and optional bootView param to boot method Signed-off-by: Marquis Kurt <software@marquiskurt.net>
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
sr229
suggested changes
Sep 10, 2019
| if not persistent.AS_COMPLETED_SETUP: | ||
| ASSetup.startSetup(express=expressSetup, disclaimer=disclaimer) | ||
|
|
||
| for app in self.gatherAllApplications(): |
Contributor
There was a problem hiding this comment.
might be better to thread startup applications so it doesn't slow down the whole process.
Member
Author
There was a problem hiding this comment.
So probably have a thread for each applicationWillLaunchAtLogin?
Contributor
There was a problem hiding this comment.
no, run a seperate init thread per startup app, this is considerably safer.
Signed-off-by: Marquis Kurt <software@marquiskurt.net>
sr229
suggested changes
Sep 11, 2019
| if not persistent.AS_COMPLETED_SETUP: | ||
| ASSetup.startSetup(express=expressSetup, disclaimer=disclaimer) | ||
|
|
||
| print("INFO: Threading any startup services...") |
Member
Author
|
To prevent conflicts, it's probably best to merge #7 first and pull those changes in. |
Signed-off-by: Marquis Kurt <software@marquiskurt.net>
…tloader, rebuild docs DB Signed-off-by: Marquis Kurt <software@marquiskurt.net>
sr229
approved these changes
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
applicationShouldLaunchAtLogin()andapplicationWillLaunchAtLoginmethods toASAppRepresentativegatherAllApplications()method toASBootloaderCoreServicebootmethod in the following ways:bootViewoptional parameter to set the custom boot loader viewapplicationWillLaunchAtLoginif they are permitted to do so.persistent.AS_SETUP_COMPLETEwhen it should have beenpersistent.AS_COMPLETED_SETUP)