Conversation
Stop spoofable XFF without trusted_proxies, block webhook SSRF and unsafe iframe URLs, confine module icon paths, tighten API-key/reset ACL, and add graceful shutdown with bounded forms and safer WebSocket origins.
Thread DDL through SyncRegistrySchemaContext, require setup_token when setup is not localhost-only, add webhook/CSRF/shutdown counters, and consolidate float coercion under orm.CoerceFloat64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sys.action.urlend-to-end (parse, sync, resolve, workspace) and embed URL actions in an iframe workspace instead of falling back to Apps.false→ SQLNULLsemantics across ORM search and record rules.trusted_proxiesfor XFF, webhook SSRF checks, safe iframe URLs, confined module-icon paths, tighter API-key/reset ACL, form body limits, WS origin checks, and graceful SIGTERM shutdown.Commits
fix(orm): compile Many2One false domains as NULL checksfix(orm): unify falsy domain semantics across field typesfeat(web): support sys.action.url and embed URL actions in workspacefix(ci): type IframeView props and sync iframeUrl payload contractfix(swc): restore Many2One search and select-style autocomplete UXfix(security): harden trust boundaries and production HTTP lifecycleTest plan
trusted_proxies, spoofedX-Forwarded-For: 127.0.0.1does not pass setup localhost gatewebhook:http://127.0.0.1/...server actions are rejected;javascript:iframe URLs rejecteduser_id; reset-password requires system adminDeploy notes
trusted_proxies(CIDRs of reverse proxies) when running behind a load balancer; empty means XFF is ignored.make swc) —swc.jsis gitignored.