Skip to content

Conversation

@ryanio
Copy link
Collaborator

@ryanio ryanio commented Nov 3, 2025

Summary

  • Added item: BaseItemType field to OrderValidationEventPayload to provide type-safe access to NFT identifiers (including nft_id) in order invalidate and revalidate events
  • Fixed package.json formatting (via prettier)

Details

The item field includes the nft_id property which follows the format: "chain/contract_address/token_id" (e.g., "ethereum/0x5a2109c839aed0a1b7914abfe0e67de38d5a2992/40").

Note: CollectionOfferEventPayload was intentionally not modified as collection offers apply to any NFT in a collection rather than a specific NFT ID.

Test plan

  • Verify TypeScript types compile successfully
  • Confirm nft_id is accessible on order validation events
  • Validate the format matches expected pattern

🤖 Generated with Claude Code

This adds the item field (which includes nft_id) to OrderValidationEventPayload, enabling type-safe access to NFT identifiers in order invalidate and revalidate events. The nft_id follows the format: "chain/contract_address/token_id".

Note: CollectionOfferEventPayload was intentionally not modified as collection offers apply to any NFT in a collection rather than a specific NFT.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coveralls
Copy link

coveralls commented Nov 3, 2025

Coverage Status

coverage: 75.159%. remained the same
when pulling 5a2ddcc on add-nft-id-to-item
into 0a8539b on main.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ryanio ryanio merged commit 11aa30a into main Nov 3, 2025
10 checks passed
@ryanio ryanio deleted the add-nft-id-to-item branch November 3, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants