Skip to content

Avoid duplicate / inconsistent environment descriptors #71

@brian-rose

Description

@brian-rose

As discussed in #68 and #70, we currently have two different descriptions of the sphinx build environment:

  • requirements.txt is used by pip
    • on readthedocs for automated testing of PRs
    • on GitHub Actions to build and deploy the actual portal site
  • ci/environment.yml is used by conda, which we recommend for local building in our Contributor's Guide

We have no automated way to checking for inconsistencies between these two, which recently led to a local build error #68 . Clearly it's not ideal that our CI tests are not catching this.

A few paths forward:

  1. Modify both GitHub Actions and readthedocs to use conda instead of pip, making sure they are building in a way that is consistent with our own local build instructions (my preference)
  2. Change our Contributor's Guide to suggest using pip instead of conda (I don't think this is a good idea)
  3. Find a CI tool that will automatically check for inconsistencies between the two environment files? (I don't know how to do this, but even if I did, it seems like a band-aid solution compared to 1.)

Thoughts from the Infrastructure team?

Metadata

Metadata

Assignees

No one assigned

    Labels

    infrastructureInfrastructure related issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions