-
Notifications
You must be signed in to change notification settings - Fork 24
Closed
Labels
infrastructureInfrastructure related issueInfrastructure related issue
Description
As discussed in #68 and #70, we currently have two different descriptions of the sphinx build environment:
requirements.txtis used by pip- on readthedocs for automated testing of PRs
- on GitHub Actions to build and deploy the actual portal site
ci/environment.ymlis used by conda, which we recommend for local building in our Contributor's Guide
We have no automated way to checking for inconsistencies between these two, which recently led to a local build error #68 . Clearly it's not ideal that our CI tests are not catching this.
A few paths forward:
- Modify both GitHub Actions and readthedocs to use conda instead of pip, making sure they are building in a way that is consistent with our own local build instructions (my preference)
- Change our Contributor's Guide to suggest using pip instead of conda (I don't think this is a good idea)
- Find a CI tool that will automatically check for inconsistencies between the two environment files? (I don't know how to do this, but even if I did, it seems like a band-aid solution compared to 1.)
Thoughts from the Infrastructure team?
Metadata
Metadata
Assignees
Labels
infrastructureInfrastructure related issueInfrastructure related issue