Make environment.yml consistent with requirements.txt #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
ktyle
reviewed
Apr 28, 2021
Contributor
ktyle
left a comment
ktyle
left a comment
There was a problem hiding this comment.
In my case, I did not add pyyaml ... suspect it got installed as a prereq when building the conda environment. Is pyyaml included in the requirements.txt, so you included it here for consistency?
Member
Author
Yes, exactly. I just made this list mirror exactly what's in |
Contributor
|
@brian-rose yes, #68 builds fine now on Linux. |
ktyle
approved these changes
Apr 28, 2021
andersy005
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
This just makes our
ci/environment.ymlfile (used by conda to make the build environment when building the site locally) consistent withrequirements.txt(used by pip to make the build environment on readthedocs)It would be better to avoid duplicating the build requirements. I'll open a separate issue about that.