Skip to content

Basic automated test to verify the essential behavior of Bacta Toss #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Josh-Larson merged 3 commits into from
Jan 13, 2025
Merged

Basic automated test to verify the essential behavior of Bacta Toss #1731

Josh-Larson merged 3 commits into from
Jan 13, 2025

Conversation

@madsboddum
Copy link
Member

@madsboddum madsboddum commented Dec 20, 2024

Helps us keep Bacta Toss working when completing #1714.

@madsboddum madsboddum self-assigned this Dec 20, 2024
@madsboddum
Copy link
Member Author

madsboddum commented Dec 20, 2024

Not entirely sure why BactaTossTest#healFriendlyTarget fails, but it does so quite consistently.
The object delta is simply not being sent to the medic, despite the target actually being healed according to the log.

@Undercova
Copy link
Member

Undercova commented Jan 4, 2025

Not entirely sure why BactaTossTest#healFriendlyTarget fails, but it does so quite consistently. The object delta is simply not being sent to the medic, despite the target actually being healed according to the log.

Medic and patient are neutral ?

@madsboddum
Copy link
Member Author

madsboddum commented Jan 4, 2025

Medic and patient are neutral ?

Yep. Maybe it's just listening for the wrong delta 🤔

@madsboddum madsboddum force-pushed the simple-bacta-toss-test branch from c69f7ea to 9e75f0b Compare January 12, 2025 02:27
@madsboddum
Fixed some flaky behavior in TrappingXPTest#scoutsGetTrappingXPFromKi…
cfb1b4b 
…llingCreatures, by simply waiting for the trapping XP to be granted before asserting
@Josh-Larson Josh-Larson merged commit 758fa90 into ProjectSWGCore:master Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Larson Josh-Larson Awaiting requested review from Josh-Larson

Assignees

@madsboddum madsboddum

Labels

[Engine] Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madsboddum @Undercova @Josh-Larson