refactor: extract common attribute parsing logic in derive macros#472
Merged
eigmax merged 4 commits intoProjectZKM:pre-release-v1.2.5from Mar 17, 2026
Merged
Conversation
…ark proo…" (ProjectZKM#470) This reverts commit 7af605d.
* Reapply "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (ProjectZKM#470) This reverts commit 537c656. * test: fix expected string
felicityin
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract duplicated attribute parsing code into a single
find_attr_pathhelper function. Four nearly identical functions (find_execution_record_path, find_program_path, find_error_path, find_builder_path) now delegate to one shared implementation, reducing code duplication from ~60 lines to ~20.