Merged
Conversation
…nark proo…" (ProjectZKM#470) This reverts commit 537c656.
eigmax
added a commit
that referenced
this pull request
Mar 17, 2026
* fix(sdk): clarify proof bytes() encoding for compressed vs snark proofs (#466) * Revert "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 7af605d. * chore: fix expected string (#471) * Reapply "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 537c656. * test: fix expected string * refactor: extract common attribute parsing logic in derive macros --------- Co-authored-by: GarmashAlex <garmasholeksii@gmail.com> Co-authored-by: Stephen Duan <81497928+eigmax@users.noreply.github.com> Co-authored-by: Jingping Yin <yinjingping2022@gmail.com>
eigmax
added a commit
that referenced
this pull request
Mar 20, 2026
* fix(sdk): clarify proof bytes() encoding for compressed vs snark proofs (#466) * Revert "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 7af605d. * chore: fix expected string (#471) * Reapply "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (#470) This reverts commit 537c656. * test: fix expected string * fix(prover): remove leftover debug code (#473) * feat: build groth16 vk without verifying stark vk * fix: add part vk in the circuit * style: cargo fmt * fix: replace addition with hashing * feat: add script * feat: add 'common' feature * style: refactor * chore: update vks * style: refactor * feat: get part start vk by version * style: refactor * fix: ci * style: rename feature, var and func * feat: get partial stark vk locally * feat: arkwork verifier * style: refactor --------- Co-authored-by: GarmashAlex <garmasholeksii@gmail.com> Co-authored-by: Stephen Duan <81497928+eigmax@users.noreply.github.com> Co-authored-by: emmmm <155267286+eeemmmmmm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.