feat: build a groth16 vk that is not affected by Ziren upgrades#481
Merged
eigmax merged 21 commits intoProjectZKM:pre-release-v1.2.5from Mar 20, 2026
Merged
Conversation
…ark proo…" (ProjectZKM#470) This reverts commit 7af605d.
* Reapply "fix(sdk): clarify proof bytes() encoding for compressed vs snark proo…" (ProjectZKM#470) This reverts commit 537c656. * test: fix expected string
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
from
5a6501b to
84398af
Compare
felicityin
changed the title
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
from
84398af to
ec15e34
Compare
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
4 times, most recently
from
a946f71 to
b399b00
Compare
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
from
b399b00 to
053c558
Compare
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
from
2c91425 to
6326b6d
Compare
eigmax
reviewed
Mar 19, 2026
eigmax
reviewed
Mar 19, 2026
eigmax
reviewed
Mar 20, 2026
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
from
f59c964 to
2518afd
Compare
felicityin
force-pushed
the
bitvm2-groth16-vk-v2
branch
from
2518afd to
9220619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid changes in groth16 vk after ziren upgrade,
vk_commitmentandpc_startwill not be verified in the groth16 circuit, but will be placed in public inputs for verification.When Ziren upgrades, only needs to update
cracks/verifier/bn254-vk/part_dark-vk.bin, without updatingcracks/verifier/bn254-vk/imm_groth16_vk.binTest