fix(host-tauri): get_window was removed from tauri::Manager, use get_webview_window - #168
Merged
Merged
Conversation
…webview_window Tauri 2.x renamed AppHandle::get_window to get_webview_window (webview windows are no longer the only window kind). This call site pre-dates that rename and was never caught because the whole workspace has been failing to compile on the Windows target since specta 2.0.0-rc.25 started requiring an unstable nightly-only feature (debug_closure_helpers) that only became usable on stable with a recent rustc bump — nothing downstream of specta in the dependency graph, including this file, was ever actually reached by `cargo check` until now. Also swaps the now-unused `tauri::Emitter` import for `tauri::Manager`, whose trait provides get_webview_window. Verified: `cargo check --workspace --target x86_64-pc-windows-gnu` and `cargo check --workspace --exclude ledgerr-host` both clean (only pre-existing lint warnings, nothing new). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
elasticdotventures
added a commit
to elasticdotventures/_b00t_
that referenced
this pull request
Aug 9, 2026
…on/ledgrrr#168) Follow-up to the earlier reconciliation bump in this branch: updating rustup's stable toolchain (1.91.1 -> 1.97.1) unblocked the specta unstable-feature build error that had been silently masking the rest of the dependency graph on the Windows target -- which turned up one real, pre-existing bug (Tauri renamed get_window to get_webview_window). Fixed upstream and verified `cargo check --workspace --target x86_64-pc-windows-gnu` clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
elasticdotventures
added a commit
to elasticdotventures/_b00t_
that referenced
this pull request
Aug 9, 2026
* chore(vendor): sync ledgrrr to reconciled b00t-patches (PromptExecution/ledgrrr#167) The submodule pin had been tracking fix/tray-native-windows-rs-062 directly (via a series of one-off "bump vendor/ledgrrr for X fix" commits) rather than b00t-patches, the branch .gitmodules actually declares — the two diverged after b00t-patches was rebased/force-pushed upstream, and each accumulated independent commits, including two independent fixes for the same windows_registry Result-shadowing bug. PromptExecution/ledgrrr#167 reconciled both lineages back into b00t-patches (34 commits from the tray branch: desktop-server unification gh#118, .mcpb packaging #120, settings HTTP-server refactor, kani-proof downgrades, Windows tray/registry fixes; 3 from b00t-patches: native tray wiring, opencode MCP compat, an independent Result-shadowing fix — deduplicated during merge). This bump points the pin back at what .gitmodules actually declares, with nothing lost. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * feat(doctor): detect submodule pins stranded off their declared branch check-submodule-drift.sh's existing checks only ever compared a submodule's checked-out HEAD against the recorded .gitmodules pin — they had no way to notice the pin itself becoming unreachable from the branch .gitmodules declares (branch = ...) after that branch gets force-pushed/rebased upstream. That's exactly how vendor/ledgrrr silently stranded 34 commits on an orphan lineage for weeks (see PromptExecution/ledgrrr#167 and `b00t lfmf ledgrrr-sync` for the full incident) — every existing check reported "ok" the whole time. Adds a branch_status field (ok/stale/unknown/n/a) per submodule, local-only by design (never fetches over the network at check time — see the same day's WSL2 + Cloudflare WARP MTU-blackhole incident for why a per-submodule network call on every `b00t doctor check` is a bad idea). `stale` is counted as a doctor-check failure; `unknown` (branch not fetched locally yet) is not. Threaded through doctor_cmd.rs's JSON detail/unresolved-count and human-readable output, plus three new bats regression tests (ok/stale/unknown) mirroring the real incident's shape via a force-pushed fixture branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore(vendor): bump ledgrrr for get_webview_window fix (PromptExecution/ledgrrr#168) Follow-up to the earlier reconciliation bump in this branch: updating rustup's stable toolchain (1.91.1 -> 1.97.1) unblocked the specta unstable-feature build error that had been silently masking the rest of the dependency graph on the Windows target -- which turned up one real, pre-existing bug (Tauri renamed get_window to get_webview_window). Fixed upstream and verified `cargo check --workspace --target x86_64-pc-windows-gnu` clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tauri 2.x renamed
AppHandle::get_windowtoget_webview_window. This call site pre-dates that rename and was masked entirely — the whole workspace has been failing to compile on the Windows target sincespecta 2.0.0-rc.25started requiring an unstable nightly-only feature (debug_closure_helpers) that a recent rustc stable bump made usable — nothing downstream ofspectain the dependency graph, including this file, was ever actually type-checked bycargo checkuntil the toolchain was updated (as part of #167's follow-up verification).Test plan
cargo check --workspace --target x86_64-pc-windows-gnu— clean, only pre-existing lint warningscargo check --workspace --exclude ledgerr-host(native Linux) — clean🤖 Generated with Claude Code