Feat/lfmf ontology tools#75
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- parser.rs: convert outer doc comment to inner module doc (//!) and move before use statements - ledger_ops.rs: fix write_sheet to use correct headers matching TxProjectionRow fields (tx_id, account_id, date, amount, description, source_ref) and write all field values - verify.rs: make test_verification_rejected_low_confidence actually invoke verifier.verify() and assert !is_approved() Agent-Logs-Url: https://github.com/PromptExecution/l3dg3rr/sessions/b1a08908-ae43-4870-9678-d6b9ef09c136 Co-authored-by: elasticdotventures <35611074+elasticdotventures@users.noreply.github.com>
…es-20260503-134158 feat: checkpoint workspace core updates
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is primarily a broad formatting/reflow sweep across the workspace, with touches in the ontology/MCP/evidence-related areas and one substantive change in ledger-core's workbook export path. In the overall codebase, it mostly preserves existing behavior while tidying many Rust files, but the export change alters what downstream workbook consumers receive.
Changes:
- Applies widespread Rust formatting/import wrapping updates across
mdbook-rhai-mermaid,ledgerr-mcp,ledgerr-host,ledger-core,datum,b00t-iface, andarc-kit-au. - Reflows several MCP/ontology/evidence/Xero-related modules without materially changing most logic.
- Changes
ledger-coreworkbook export sheet headers/columns inledger_ops.rs.
Reviewed changes
Copilot reviewed 75 out of 76 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
xtask/src/viz_manifest.rs |
Formatting-only reflow of visualization manifest entries. |
crates/mdbook-rhai-mermaid/src/parser.rs |
Formatting/module-doc cleanup in parser and tests. |
crates/mdbook-rhai-mermaid/src/main.rs |
Formatting-only updates in book processing/tests. |
crates/mdbook-rhai-mermaid/src/emitter.rs |
Formatting-only updates in Mermaid emitter/tests. |
crates/ledgerr-xero/src/auth.rs |
Formatting-only line wrap in auth flow. |
crates/ledgerr-mcp/src/xero_service.rs |
Formatting-only wrap in pending-auth lookup. |
crates/ledgerr-mcp/src/providers/definitions.rs |
Formatting-only import/assert wrapping. |
crates/ledgerr-mcp/src/mcp_adapter.rs |
Formatting-only reflow in adapter/tool handling. |
crates/ledgerr-mcp/src/lib.rs |
Minor reordering/reflow; no substantive behavior found in changed hunks. |
crates/ledgerr-mcp/src/gate.rs |
Formatting-only import wrapping. |
crates/ledgerr-mcp/src/contract.rs |
Formatting-only reflow in tool contract/evidence args. |
crates/ledgerr-mcp/src/bin/ledgerr-mcp-server.rs |
Formatting-only reflow in server dispatch/build helpers. |
crates/ledgerr-mcp/src/actor.rs |
Formatting cleanup in actor dispatch/tests. |
crates/ledgerr-mcp-core/src/provider.rs |
Formatting-only reflow in provider registry/tests. |
crates/ledgerr-host/tests/visualization_e2e.rs |
Formatting-only test cleanup. |
crates/ledgerr-host/tests/phi4_smoke.rs |
Formatting-only line wrap in smoke test. |
crates/ledgerr-host/src/settings/schema.rs |
Formatting-only signature wrapping. |
crates/ledgerr-host/src/local_llm_mistral.rs |
Formatting-only reflow in local Mistral runtime. |
crates/ledgerr-host/src/local_llm.rs |
Formatting-only import/reflow changes. |
crates/ledgerr-host/src/lib.rs |
Minor reordering/reflow of re-exports. |
crates/ledgerr-host/src/internal_openai.rs |
Formatting-only reflow in provider helpers/tests. |
crates/ledgerr-host/src/evidence.rs |
Formatting-only import/order cleanup. |
crates/ledgerr-host/src/bin/host-window.rs |
Formatting-only reflow in window geometry setup. |
crates/ledger-core/tests/type_mesh.rs |
Formatting-only test cleanup. |
crates/ledger-core/tests/rhai_rules_extended.rs |
Formatting-only test reflow. |
crates/ledger-core/tests/rhai_rules.rs |
Formatting-only test reflow. |
crates/ledger-core/tests/legal_z3_integration.rs |
Formatting-only test reflow. |
crates/ledger-core/tests/iso_lint.rs |
Formatting-only macro/test reflow. |
crates/ledger-core/src/workflow.rs |
Formatting-only reflow in workflow validation/rendering. |
crates/ledger-core/src/visualize.rs |
Formatting-only reflow in visualization helpers/tests. |
crates/ledger-core/src/verify.rs |
Mostly formatting; one test now asserts low-confidence rejection instead of placeholder behavior. |
crates/ledger-core/src/validation.rs |
Formatting-only reflow in meta/verb helpers. |
crates/ledger-core/src/slint_viz.rs |
Formatting-only trailing brace normalization. |
crates/ledger-core/src/render.rs |
Formatting-only line compaction. |
crates/ledger-core/src/pipeline.rs |
Formatting-only reflow in pipeline types/tests. |
crates/ledger-core/src/ontology.rs |
Formatting-only reflow of arc-kit re-exports. |
crates/ledger-core/src/observability.rs |
Formatting-only reflow in parser/rule/tests. |
crates/ledger-core/src/lib.rs |
Minor module reorder. |
crates/ledger-core/src/legal.rs |
Formatting-only reflow in legal solver/tests. |
crates/ledger-core/src/ledger_ops.rs |
Substantive workbook export column/header change plus general reflow. |
crates/ledger-core/src/layout.rs |
Formatting-only import/order cleanup. |
crates/ledger-core/src/iso_objects.rs |
Formatting-only reflow in visualization specs. |
crates/ledger-core/src/iso.rs |
Formatting-only reflow in DSL/animation helpers/tests. |
crates/ledger-core/src/integration_tests.rs |
Formatting-only reflow in integration tests. |
crates/ledger-core/src/graph.rs |
Formatting-only vector literal compaction. |
crates/ledger-core/src/document_shape.rs |
Formatting-only reflow in classifier/tests. |
crates/ledger-core/src/constraints.rs |
Formatting-only reflow in constraints/tests. |
crates/ledger-core/src/calendar.rs |
Formatting-only reflow in calendar helpers/defaults/tests. |
crates/datum/src/tomllmd.rs |
Formatting-only reflow in TOMLLMD parsing/rendering/tests. |
crates/datum/src/protocol.rs |
Formatting-only reflow in protocol helpers/tests. |
crates/datum/src/logic.rs |
Formatting-only reflow in logic helpers/tests/macros. |
crates/datum/src/lib.rs |
Formatting-only enum/test reflow. |
crates/datum/src/ast.rs |
Formatting-only parser/lint reflow. |
crates/b00t-iface/src/viz/mod.rs |
Formatting-only SVG/viz reflow. |
crates/b00t-iface/src/sarif/mod.rs |
Formatting-only reflow in SARIF generation/tests. |
crates/b00t-iface/src/ralph.rs |
Formatting-only reflow in research loop/tests. |
crates/b00t-iface/src/metric/mod.rs |
Formatting-only reflow in metric registry/tests. |
crates/b00t-iface/src/llm/mod.rs |
Formatting-only import/log reflow. |
crates/b00t-iface/src/lib.rs |
Minor module reorder. |
crates/b00t-iface/src/handshake/mod.rs |
Formatting-only reflow in handshake surface. |
crates/b00t-iface/src/gated/mod.rs |
Minor module reorder. |
crates/b00t-iface/src/gated/autoresearch.rs |
Formatting-only reflow in autoresearch surface/tests. |
crates/b00t-iface/src/exec/harness.rs |
Formatting-only reflow in lifecycle harness. |
crates/b00t-iface/src/core/surface.rs |
Formatting-only path/error reflow. |
crates/b00t-iface/src/core/promise.rs |
Formatting-only reflow in promise helpers/tests. |
crates/b00t-iface/src/core/mod.rs |
Minor module/re-export reorder. |
crates/b00t-iface/src/core/machine.rs |
Formatting-only reflow in state machine/tests. |
crates/b00t-iface/src/core/governance.rs |
Formatting-only reflow in governance constraints. |
crates/arc-kit-au/src/trace.rs |
Formatting-only import reorder. |
crates/arc-kit-au/src/store.rs |
Formatting-only import reorder. |
crates/arc-kit-au/src/missing.rs |
Formatting-only reflow in provenance scanner/tests. |
crates/arc-kit-au/src/lib.rs |
Minor module/re-export reorder. |
crates/arc-kit-au/src/graph.rs |
Formatting-only reflow in graph helpers/tests. |
crates/arc-kit-au/src/edge.rs |
Formatting-only constructor/trait signature reflow. |
crates/arc-kit-au/src/builder.rs |
Formatting-only reflow in builder helpers/tests. |
crates/arc-kit-au/src/badge.rs |
Formatting-only reflow in provenance badge/tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+459
to
+467
| ws.write_string(0, 1, "account_id") | ||
| .map_err(|e| LedgerOpError::Workbook(e.to_string()))?; | ||
| ws.write_string(0, 2, "date") | ||
| .map_err(|e| LedgerOpError::Workbook(e.to_string()))?; | ||
| ws.write_string(0, 3, "amount") | ||
| .map_err(|e| LedgerOpError::Workbook(e.to_string()))?; | ||
| ws.write_string(0, 4, "description") | ||
| .map_err(|e| LedgerOpError::Workbook(e.to_string()))?; | ||
| ws.write_string(0, 5, "source_ref") |
…clippy baseline Resolved 17 conflict regions across 10 files: - machine.rs: take MERGE_SOURCE's AuditRecord import - harness.rs: keep .clone() for moved value (fix from #74) - sarif/mod.rs: keep HEAD's collapsed if-chains and _mermaid_results prefix - ledger_ops.rs: take MERGE_SOURCE's 6-column expanded schema - verify.rs: keep MERGE_SOURCE's explanatory comment - visualize.rs: keep HEAD's Kasuari constraint solver + test coverage - provider.rs: keep HEAD's simpler .cloned() chain - mcp-server.rs: keep HEAD's implicit closure in get_or_init - mcp_adapter.rs: keep HEAD's _registry-less handle_external_tool - parser.rs: take MERGE_SOURCE's //! doc comment style Also fixed pre-existing warnings: unused AuditRecord import in machine.rs, sort_by_key lint in lfmf-counter, unused EdgeType import in ledgerr-mcp.
Signed-off-by: Brian Horakh <35611074+elasticdotventures@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.