v0.1.28
Summary
Two small, related cleanups to the communication-preferences feature added in #195:
-
Restore the confirm-password autocomplete regression test. #195 accidentally deleted the
defline fortest_register_page_confirm_password_has_autocomplete, collapsing its body intotest_register_page_shows_password_requirementsand demoting its docstring to a no-op string statement. The issue #156 autocomplete check is restored as its own test. The comm-preference assertions remain intest_register_page_shows_password_requirements, where they correctly verify the register page renders the new fields. -
Drop the
syncSubPreferenceshelper. Incommunication_preferences_fields.htmlthe helper was only ever called from the master checkbox'schangehandler (disable branch) and never on init — initial visibility is already set server-side via the Jinjastyle="display: none;"guard. Inlining it removes the indirection and the enable/disable asymmetry. Behavior is preserved exactly: enabling reveals the sub-preferences and checkscomm_updates; disabling hides them and clears both sub-preferences.
Test plan
-
uv run pytest tests/routers/core/test_account.py(91 passed) -
uv run pytest tests/test_templates.py(30 passed) - Both
test_register_page_shows_password_requirementsandtest_register_page_confirm_password_has_autocompleteare collected as separate tests -
uv run ty check .clean