fix(docs): drop cross-repo symbol backticks tripping OC phantom-symbol gate - #324
Merged
Merged
Conversation
…l gate The cross-repo remediation roadmap backtick-referenced `p95_latency_ms` (a SwitchBoard symbol). OC's K1/OC8 phantom-symbol detectors only know OC's own src, so they flagged it — turning the custodian-audit job red on main after #323 merged (the reviewer LGTM-merged over the advisory, non-required check). K1 suppresses via known_values only (no per-file exclude), so the clean fix is to drop the backticks on the cross-repo symbol. Audit now down to the sole environmental B2 (boundary artifact, materialized from a secret in CI). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for the audit regression introduced when #323 merged.
What happened: the cross-repo roadmap doc backtick-referenced
p95_latency_ms(a SwitchBoard symbol). OC's K1/OC8 phantom-symbol detectors only know OC's ownsrc, so they flagged it — turning thecustodian-auditjob red on main. #323 merged anyway because main isn't branch-protected and the reviewer LGTM-merges over the advisory (non-required) audit check.Fix: K1 has no per-file exclude (it suppresses via
known_valuesonly), so the clean root-cause fix is to drop the backticks on that one cross-repo symbol reference. Verified with the working detector: audit goes from 3 findings → 1, and the remaining one is the environmental B2 (boundary artifact, materialized from a secret in CI — green on the prior main runs).Governance note (follow-up): the
auditgate is currently advisory — main is unprotected and the reviewer doesn't gate on it, so a red audit doesn't block a merge. Making it required is blocked on B2 being made reliable (tracked as backbone item B2/B3 in the remediation roadmap).🤖 Generated with Claude Code