fix linting - #5
Merged
Merged
Conversation
go 1.26's go vet rejects passing a non-constant string (err.Error()) as the format argument to status.Errorf. Pass it via %s so the error can never be misinterpreted as a format string. Surfaced while wiring the dev-kit quality gate (go test ./... runs vet).
…igure quality gate, workflow anchor, e2e runbook)
Vendor the dev-kit runtime (v0.5.5) into the repo so every teammate gets the
pipeline on git pull with no per-user setup:
- .claude/skills/{dev-kit,work-*}, .claude/agents/{coder,e2e-tester},
.claude/hooks/quality-gate.sh, dev-kit.manifest
- Routed quality gate (.claude/quality-gate.routes): per-service Go + C# build/test
(shipping, productcatalog, frontend, checkout, cartservice) + protos composite;
Node/Python/Java left to each task's acceptance check (not CI-tested).
- CLAUDE.md workflow anchor + per-service Commands + Structure.
- docs/test/README.md e2e runbook: full-stack skaffold bring-up + per-service smokes.
- Branch-per-unit + squash-PR policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bootstraps the dev-kit spec-driven pipeline into this repo so every teammate gets it on
git pullwith no per-user setup. Vendored runtime v0.5.5.Vendored runtime (
.claude/)skills/{dev-kit,work-research,work-tests,work-plan,work-execute,work-docs}agents/{coder,e2e-tester},hooks/quality-gate.sh,dev-kit.manifestQuality gate — routed (polyglot repo)
.claude/quality-gate.routesruns only the service that changed:src/shippingservicego build ./...go test ./...src/productcatalogservicego build ./...go test ./...src/frontendgo build ./...go test ./...src/checkoutservicego build ./...go test ./...src/cartservicedotnet build …slndotnet test …protos/Scope confirmed with the team: Go + C# only — what CI unit-tests (
.github/workflows/ci-pr.yaml) and the only stacks that build/test fast without Docker/a cluster. Node/Python/Java (adservice) changes fall to each task's acceptance check + the full skaffold e2e.Config
CLAUDE.md— workflow anchor (orchestrator discipline), per-service Commands, Structure.docs/test/README.md— e2e runbook: full-stack skaffold bring-up + per-service browser smokes.Also included
fix(checkoutservice):status.Errorf(codes.Internal, err.Error())→%sverb — a pre-existing go-1.26 vet failure surfaced while wiring the gate (CI never tested checkout).Verification
docs/work/artifacts only produce a non-blocking NOTE..claude/anddocs/not gitignored.Note for reviewers
The pipeline activates only when Claude Code starts with this repo as root. After merge, restart in the repo dir to use it. Native-Windows devs need
bashon PATH (Git Bash/WSL) for the gate hook.