Skip to content

Docs/conventions hygiene batch: CLAUDE.md rules + proposal doc corrections - #100

Merged
WilfordGrimley merged 3 commits into
masterfrom
docs-conventions-hygiene-batch-cvq14g
Jul 18, 2026
Merged

Docs/conventions hygiene batch: CLAUDE.md rules + proposal doc corrections#100
WilfordGrimley merged 3 commits into
masterfrom
docs-conventions-hygiene-batch-cvq14g

Conversation

@WilfordGrimley

@WilfordGrimley WilfordGrimley commented Jul 18, 2026

Copy link
Copy Markdown

Summary

Consolidated docs/conventions hygiene batch — 7 items, each a decided convention or correction from today's work needing its permanent home.

  1. CLAUDE.md conventions:
  2. Proprietary-name genericization: "Proxxied" (proposal-b, proposal-c, proposal-g) and "Steam Deck" (proposal-b) design-reference mentions genericized. A broad follow-up grep across all of docs/ (including an independent research-agent sweep) found no further hits. "Moxfield" kept as-is (named factual import source); historical docs/reports/ files untouched.
  3. proposal-c-context-menu-restyle.md: Part (b) (solid-color utilitarian restyle direction) marked SUPERSEDED by Proposal H, which absorbs the restyle direction. Kept as a historical record, not an active plan.
  4. proposal-b-bleed-normalization.md: decision 4's persistence note corrected. It originally (written before PR-2 shipped) said persistence was "project state (projectSlice), not session-only," which reads as SavedDeck-style project/cloud persistence. What actually shipped is identifier-keyed localStorage (deliberately device-local, mirroring favoritesSlice), consistent with projectSlice holding a live Redux copy but localStorage being what actually survives reload — and consistent with proposal-g's own §5, which already correctly describes this as deliberately kept out of SavedDeck state.
  5. proposal-h-unified-display-page.md §1: corrected alex-taxiera/proxy-print's license label from MIT to AGPL-3.0 (verified directly against its actual GitHub license metadata) — confirmed correct by the owner. acoreyj/proxies-at-home's own MIT label is correct and unchanged.
  6. docs/lessons.md — two new entries, both checked-for-and-absent beforehand (PR /whatsthat: fix oversized starburst + swap accent to an AA-verified navy against the orange bg #91's own diff only touched cardPanel.tsx/whatsthat.tsx, no docs):
  7. Standard close: docs_lint.py and pinned prettier (v2.7.1) run clean across every file this batch touched. Wiki: no separate wiki edit needed — this batch is docs/CLAUDE.md-only (no user- or admin-facing product change), and the automated wiki republish on merge covers today's process-evolution documentation itself.

Test plan

🤖 Generated with Claude Code

https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt

CLAUDE.md:
- Report-relay: replies must carry the full GitHub blob URL to the
  pushed report, not just branch+path.
- New merge-duty rule: never delete a branch in the same action as
  merging its PR; precondition `gh pr list --base <branch>` empty
  before deleting (this is how PR #88 was lost to the stacked-PR
  base-deletion trap).
- New rule: search for an existing recovery before rebuilding a
  lost/auto-closed PR (two sessions rebuilt #88 in parallel; #95
  duplicated #94's already-shipped recovery).

docs/proposals/proposal-b-bleed-normalization.md:
- Correct decision 4's stale pre-PR-2 persistence note: the shipped
  mechanism is identifier-keyed localStorage (device-local, mirroring
  favoritesSlice), not SavedDeck/project-cloud state, matching
  proposal-g's own §5 description of the same mechanism.
- Genericize "Proxxied"/"Steam Deck" design-reference mentions.

docs/proposals/proposal-c-context-menu-restyle.md:
- Mark Part (b) (solid-color utilitarian restyle) SUPERSEDED by
  Proposal H, which absorbs the restyle direction.
- Genericize a "Proxxied" design-reference mention.

docs/proposals/proposal-g-user-accounts-saved-decks.md:
- Genericize a "Proxxied" design-reference mention.

docs/proposals/proposal-h-unified-display-page.md:
- Correct alex-taxiera/proxy-print's license label from MIT to
  AGPL-3.0 (verified against its actual GitHub license metadata);
  acoreyj/proxies-at-home remains correctly MIT.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
WilfordGrimley pushed a commit that referenced this pull request Jul 18, 2026
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
claude added 2 commits July 18, 2026 23:10
- "A value carried verbatim out of its old context can silently stop
  meaning what it meant": generalizes PR #91's starburst width%
  (relative to a column width that changed under it) together with
  PR #78's existing "extracts X verbatim" entry as two instances of
  the same class.
- "Bootswatch Superhero hardcodes some component colors as literal
  properties, not CSS custom-property references": PR #91's
  .btn-primary background-color finding — verify computed styles on a
  live element, not just that a --bs-* custom property resolved
  correctly.

Neither was captured in docs/lessons.md by PR #91 itself (checked: its
diff only touched cardPanel.tsx and whatsthat.tsx).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
WilfordGrimley pushed a commit that referenced this pull request Jul 18, 2026
@WilfordGrimley
WilfordGrimley merged commit 7019c67 into master Jul 18, 2026
2 checks passed
@WilfordGrimley
WilfordGrimley deleted the docs-conventions-hygiene-batch-cvq14g branch July 18, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants