Docs/conventions hygiene batch: CLAUDE.md rules + proposal doc corrections - #100
Merged
Merged
Conversation
CLAUDE.md: - Report-relay: replies must carry the full GitHub blob URL to the pushed report, not just branch+path. - New merge-duty rule: never delete a branch in the same action as merging its PR; precondition `gh pr list --base <branch>` empty before deleting (this is how PR #88 was lost to the stacked-PR base-deletion trap). - New rule: search for an existing recovery before rebuilding a lost/auto-closed PR (two sessions rebuilt #88 in parallel; #95 duplicated #94's already-shipped recovery). docs/proposals/proposal-b-bleed-normalization.md: - Correct decision 4's stale pre-PR-2 persistence note: the shipped mechanism is identifier-keyed localStorage (device-local, mirroring favoritesSlice), not SavedDeck/project-cloud state, matching proposal-g's own §5 description of the same mechanism. - Genericize "Proxxied"/"Steam Deck" design-reference mentions. docs/proposals/proposal-c-context-menu-restyle.md: - Mark Part (b) (solid-color utilitarian restyle) SUPERSEDED by Proposal H, which absorbs the restyle direction. - Genericize a "Proxxied" design-reference mention. docs/proposals/proposal-g-user-accounts-saved-decks.md: - Genericize a "Proxxied" design-reference mention. docs/proposals/proposal-h-unified-display-page.md: - Correct alex-taxiera/proxy-print's license label from MIT to AGPL-3.0 (verified against its actual GitHub license metadata); acoreyj/proxies-at-home remains correctly MIT. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
WilfordGrimley
pushed a commit
that referenced
this pull request
Jul 18, 2026
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
- "A value carried verbatim out of its old context can silently stop meaning what it meant": generalizes PR #91's starburst width% (relative to a column width that changed under it) together with PR #78's existing "extracts X verbatim" entry as two instances of the same class. - "Bootswatch Superhero hardcodes some component colors as literal properties, not CSS custom-property references": PR #91's .btn-primary background-color finding — verify computed styles on a live element, not just that a --bs-* custom property resolved correctly. Neither was captured in docs/lessons.md by PR #91 itself (checked: its diff only touched cardPanel.tsx and whatsthat.tsx). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
WilfordGrimley
pushed a commit
that referenced
this pull request
Jul 18, 2026
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidated docs/conventions hygiene batch — 7 items, each a decided convention or correction from today's work needing its permanent home.
gh pr list --base <branch>must return empty before deleting. Cites how PR Proposal G, PR3: opaque-blob saved-decks API #88 was lost (stacked-PR base-deletion trap).docs/(including an independent research-agent sweep) found no further hits. "Moxfield" kept as-is (named factual import source); historicaldocs/reports/files untouched.projectSlice), not session-only," which reads as SavedDeck-style project/cloud persistence. What actually shipped is identifier-keyedlocalStorage(deliberately device-local, mirroringfavoritesSlice), consistent withprojectSliceholding a live Redux copy butlocalStoragebeing what actually survives reload — and consistent with proposal-g's own §5, which already correctly describes this as deliberately kept out ofSavedDeckstate.alex-taxiera/proxy-print's license label from MIT to AGPL-3.0 (verified directly against its actual GitHub license metadata) — confirmed correct by the owner.acoreyj/proxies-at-home's own MIT label is correct and unchanged.cardPanel.tsx/whatsthat.tsx, no docs):140%-of-column width (tuned for a 33% column, carried unchanged into a 58% column) together with the existing PR Fix Level 1's missing Scryfall reference image (regression, PR #49) #78 "extracts X verbatim" entry, as two instances of the same class..btn-primarybackground-colorfinding: verify computed styles on a live element, not just that a--bs-*custom property resolved correctly.docs_lint.pyand pinned prettier (v2.7.1) run clean across every file this batch touched. Wiki: no separate wiki edit needed — this batch is docs/CLAUDE.md-only (no user- or admin-facing product change), and the automated wiki republish on merge covers today's process-evolution documentation itself.Test plan
python3 .github/scripts/docs_lint.py— clean.npx prettier@2.7.1 --check(pinned to the repo's.pre-commit-config.yamlversion) on every touched file — clean.docs/for other proprietary product/company names used as design comparisons — none found beyond the two already fixed.frontend/src/store/slices/projectSlice.ts,frontend/src/common/cookies.ts,frontend/src/store/listenerMiddleware.ts,frontend/src/common/constants.ts) and against proposal-g's own §5 description of the same mechanism.pull_request_read— both real, merged, content matches what's cited; confirmed PR /whatsthat: fix oversized starburst + swap accent to an AA-verified navy against the orange bg #91 never toucheddocs/lessons.mditself, so the new entries aren't duplicates.🤖 Generated with Claude Code
https://claude.ai/code/session_01AHfxN9bbWAWHs8rfzVtBWt