Proposal H: scope four /editor parity gaps into unified display spec - #244
Merged
Merged
Conversation
… spec Adds deck-input landing (§4.1 rewrite), Search Settings, project-wide cardback selection, and export-beyond-PDF as tracked component-mapping gaps + migration steps, per a 2026-07-20 feature-parity audit; also corrects FinishSettings as distinct-but-unmapped (Open decision 7). Issues: #238, #239, #240, #241
WilfordGrimley
marked this pull request as ready for review
July 20, 2026 23:16
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs-only (docs/proposals/, HOLD-style spec work, no code changes): scopes four confirmed feature-parity gaps between
/editorand the already-shipped/displaypage intodocs/proposals/proposal-h-unified-display-page.md, matching the doc's existing conventions, and files a corresponding GitHub issue for each.The owner has decided
/displayshould reach FULL feature parity with/editorbefore it can supersede/editor's own route. A read-only audit found four/editorcapabilities with zero mention anywhere in this doc or infrontend/src/features/display/DisplayPage.tsx:/displaycurrently mounts zero import surfaces for an empty project, just a link back to/editor. Most urgent given the route-name decision (Open decision 1) — blocks/displayfrom ever starting a project standalone. Issue Proposal H: deck-input landing — /display can't start a project standalone #238.SearchSettings.tsx) — precise/fuzzy search type, DPI/file-size filters, source reordering. Issue Proposal H: Search Settings toolbar parity for /display #239.CommonCardback.tsx). Issue Proposal H: Cardback selection toolbar parity for /display #240.ExportXML.tsx,ExportImages.tsx,ExportDecklist.tsx—ExportPDF.tsxitself already covered via the toolbar's existing Generate PDF/Save-to-Drive mapping). Issue Proposal H: export-beyond-PDF toolbar parity for /display (XML/Images/Decklist) #241.Also verified a soft-flag:
FinishSettings.tsx(cardstock + foil) is a genuinely distinct component fromCardQualitySettings(§5's existing PDFGenerator-settings row) — not a naming collision — but has zero mapping anywhere in the doc. Per the task's own scoping, this is handled as a corrective table row + Open decision 7, not a fifth tracked gap/issue.Changes:
ImportText/ImportURL/ImportXML/ImportCSVinline whenisProjectEmpty).SearchSettings.tsx,CommonCardback.tsx, the three export components, and theFinishSettings.tsxcorrection.FinishSettingsscoping) and 8 (adding cards to a non-empty/displayproject, noted not designed).Issues filed under milestone "Proposal H: unified display", labeled
enhancement: #238, #239, #240, #241.Checklist
pre-commitand installed the hooks withpre-commit installbefore creating any commits.npx prettier@2.7.1 --check docs/proposals/proposal-h-unified-display-page.md— clean.python3 .github/scripts/docs_lint.py— clean.<Link>text lost surrounding spaces) — caught and fixed, confirmed no other instances via diff-scoped grep.