Rebuild /display left rail to editor-completion Phase 1 fidelity - #319
Merged
Conversation
Filters collapsed by default, Select Version promoted/always-open with stacked full-width disclosure, artist + confidence line promoted above the fold, Card Details/Printing Tags/Report demoted to lazy-mounted accordion sections, and dark (never-white) empty/loading/failed slot states with a deterministic Scryfall "Find this card" link. CardDetailedViewModal body extracted into CardDetailedViewBody so the rail's demoted sections and the /editor modal share one implementation; modal visual spec passes unmodified as the extraction's proof. No interactions (context menu/drag/multi-select/undo) - Phase 2.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #318 (unresolvable merge state after #317 landed; recut via cherry-pick onto current master). Content identical to #318's reviewed commit plus: docs/troubleshooting.md conflict resolved keeping both sides' entries, and #317's DisplayPage.tsx scroll-clamp verified present alongside the rail rebuild (clean auto-merge — the changes touch different regions).
Original scope (see #318's body for full detail): left rail rebuilt to reference fidelity per editor-completion spec E1–E6 (lifted CSS, filters collapsed, chip wall folded, Group-by/display-style removed, promoted artist line + D14 confidence placeholder), the §7.5 CardDetailedViewBody extraction (modal tests unmodified = proof), dark slot states with the no-white invariant (new DisplaySlotStates spec), lime corner-only cut guides building on upstream's shape (screen-side; PDF parity follows).
Verification: docs_lint clean locally; full verification delegated to CI's matrix (this recut's only hand edit was the docs conflict; DisplayPage.tsx auto-merged). The D17 pill spec and DisplaySlotStates spec in CI are the acceptance for the merge interaction.
Wiki checklist (merge-time): /display usage docs may need the rail-layout update — carried from #318.