GIS script-load failure: actionable Drive-save error (lazy-load audit: already correct)

[WilfordGrimley]

entry

Description

Two-part item: the Drive-save path was surfacing the raw "Failed to load https://accounts.google.com/gsi/client" string as the failure toast when the Google Identity Services script can't load (typically a privacy browser or ad/tracker blocker blocking accounts.google.com — a real occurrence, not hypothetical).

a. Actionable error message. frontend/src/features/googleDrive/googleDriveAuth.ts's injectScript now rejects with a new GSIScriptLoadError instead of a plain Error wrapping the raw URL. The message explains the likely cause (privacy browser/ad blocker) and gives two ways forward: allow accounts.google.com and retry, or just download the PDF instead of saving to Drive. No other code changed — the existing useSaveToDrivePDF catch handler in PDFGenerator.tsx already surfaces reason.message verbatim in the toast, so the better message flows through automatically.

b. Lazy-load audit. Traced requestGoogleDriveWriteToken's only call site (PDFGenerator.tsx's saveToDrivePDF, invoked only from the "Save PDF to Google Drive" button's click handler) — the GSI script is already injected lazily, only on first save-to-Drive click, never on page load or app mount. Nothing to convert; this is already the correct zero-telemetry-posture behavior. Also checked the separate Google Drive picker flow (GoogleDrivePicker.tsx, a different feature using @googleworkspace/drive-picker-react) — its own script loading is gated behind the picker component's own show prop, so it's lazy too, though that's a different library-managed code path outside this item's scope.

docs/features/google-drive-connect.md updated in place under "Save PDF directly to Google Drive" with both the lazy-load confirmation and the new error class.

Checklist

• I have installed pre-commit and installed the hooks with pre-commit install before creating any commits.
• I have updated any related tests for code I modified or added new tests where appropriate. New googleDriveAuth.test.ts: one test confirming a successful GSI load still resolves with the access token, one confirming a script-load failure rejects with GSIScriptLoadError and the actionable message.
• I have manually tested my changes as follows:
  • npx tsc --noEmit clean.
  • npx eslint on both files: 0 errors/warnings.
  • npx prettier@2.7.1 --check clean.
  • npx jest --runInBand src/features/googleDrive: 15/15 passing (13 pre-existing + 2 new).
  • Full npx jest --runInBand: only the pre-existing, documented QuestionFeed.test.tsx revealCard() flake fails (unrelated, reconfirmed passing in isolation).
• I have updated any relevant documentation or created new documentation where appropriate. (docs/features/google-drive-connect.md)

Merge-time checklist

• None — this is a pure error-message/verification change with no owner-only follow-up.

---

Generated by Claude Code