Skip to content

fix: symmetric compatibility#555

Merged
begumcig merged 1 commit intomainfrom
fix/complete-symmetric-compatilibities-with-new-algorithms
Mar 2, 2026
Merged

fix: symmetric compatibility#555
begumcig merged 1 commit intomainfrom
fix/complete-symmetric-compatilibities-with-new-algorithms

Conversation

@gsprochette
Copy link
Collaborator

Description

This PR adds makes the compatibilities between recently added algorithms and pre-existing algorithms symmetrical.

This issue is due to the symmetric_compatibility test not being enforced in the fast-cpu-tests in PRs because it does not have the "cpu" mark.

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Already existing test now passes, I also printed the full list of compatibilities between algorithms, 84 were missing according to the test, there are now the same compatibilities as before + the 84 previously missing ones.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

Copy link
Member

@begumcig begumcig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super good to me!

@begumcig begumcig merged commit 3623d08 into main Mar 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants