Merged
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds makes the compatibilities between recently added algorithms and pre-existing algorithms symmetrical.
This issue is due to the symmetric_compatibility test not being enforced in the fast-cpu-tests in PRs because it does not have the "cpu" mark.
Related Issue
Type of Change
How Has This Been Tested?
Already existing test now passes, I also printed the full list of compatibilities between algorithms, 84 were missing according to the test, there are now the same compatibilities as before + the 84 previously missing ones.
Checklist
Additional Notes