test: extend fast cpu tests so tests default as cpu#556
Merged
Conversation
43e688f to
8a1ec19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes cpu the default for tests, instead of relying on the cpu mark.
In total, 64 new tests will be enforced for PRs. Running those tests (and the cmmd one) took 62s on a H100 without parallelisation, the slowest one took 17s and was therefore marked as slow. Here is the pytest summary:
17.18s call tests/evaluation/test_cmmd.py::test_evaluation_agent_parameter_validation
6.49s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[clipiqa]
2.93s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[pairwise_clip_score]
2.88s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[clip_score]
2.56s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[cmmd]
2.16s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[aesthetic_laion]
1.35s call tests/telemetry/test_metrics_integration.py::test_otlp_export_to_collector
1.30s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[lpips]
1.21s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[dino_score]
1.12s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[inference_memory]
1.11s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[arniqa]
1.07s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[fid]
1.06s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[total_macs]
1.02s call tests/telemetry/test_metrics_integration.py::test_otlp_export_errors_shown_at_info_level
1.02s call tests/telemetry/test_metrics_integration.py::test_otlp_export_errors_not_shown_at_critical_level
0.94s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[sharpness]
0.92s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[accuracy]
0.90s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[energy_consumed]
0.89s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[disk_memory]
0.89s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[perplexity]
0.89s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[co2_emissions]
0.88s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[total_time]
0.88s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[ssim]
0.88s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[latency]
0.87s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[training_memory]
0.87s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[throughput]
0.86s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[psnr]
0.86s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[total_params]
0.86s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[recall]
0.85s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[precision]
0.85s call tests/evaluation/test_task.py::test_metric_initialization_from_metric_name[msssim]
0.44s call tests/evaluation/test_dino_score.py::test_dino_score
0.04s call tests/telemetry/test_metrics.py::test_set_opentelemetry_log_level
0.02s call tests/algorithms/test_compatibility_symmetry.py::test_compatibility_symmetry
0.01s call tests/evaluation/test_sharpness.py::test_sharpness_blurry_vs_sharp
0.01s setup tests/telemetry/test_metrics.py::test_basic_decorator
(159 durations < 0.005s hidden. Use -vv to show these durations.)
=== short test summary info ===
FAILED tests/algorithms/test_compatibility_symmetry.py::test_compatibility_symmetry - AssertionError: Found 84 asymmetric compatibility relationships:
=== 1 failed, 64 passed, 629 deselected, 17 warnings in 61.80s (0:01:01) ===
The failed one is fixed by #555
Related Issue
Type of Change
How Has This Been Tested?
Checked the set difference between before and after with:
pytest -m "old_conditions and not new_conditions"andpytest -m "new_conditions and not new_conditions"The 64 new tests are listed above, 3 tests were executed before and won't anymore. I would that they shouldn't run:
All new tests are passing except the compatibility one which is fixed by #555
Checklist
Additional Notes