Conversation
gsprochette
left a comment
gsprochette
left a comment
There was a problem hiding this comment.
Looks super good to me, thanks a lot :)
| "requires_whisper": "mark test that needs pruna[whisper]", | ||
| "requires_upscale": "mark test that needs pruna[upscale]", | ||
| "requires_rapidata": "mark test that needs pruna[rapidata]", | ||
| } |
There was a problem hiding this comment.
love that we have them at a single place now :)
| - name: base | ||
| extras: "" | ||
| mark_filter: "cpu and not slow and not style and not requires_intel and not requires_lmharness and not requires_rapidata" | ||
| mark_filter: "no_extras" |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9169180. Configure here.
| run: | | ||
| echo "Running tests with up to 3 reruns on failure using $PYTEST_WORKERS workers..." | ||
| uv run pytest -n $PYTEST_WORKERS -m "${{ matrix.mark_filter }}" --reruns 3 --reruns-delay 10 --maxfail=1 | ||
| uv run pytest -n $PYTEST_WORKERS -m "${{ env.DEFAULT_MARK_FILTER }} and ${{ matrix.mark_filter }}" --reruns 3 --reruns-delay 10 --maxfail=1 |
There was a problem hiding this comment.
DEFAULT_MARK_FILTER narrows lmharness and rapidata test selection
Low Severity
The DEFAULT_MARK_FILTER ("cpu and not slow and not style") is now unconditionally prepended to every matrix entry's mark_filter. Previously, lmharness and rapidata ran with only their own mark (e.g., -m "requires_lmharness"), meaning all tests with that mark were selected regardless of other marks. Now they get -m "cpu and not slow and not style and requires_lmharness", which silently excludes any lmharness or rapidata test that is also marked slow. No current tests are affected, but this is a behavioral change from the original CI config that could cause future tests to be silently skipped.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 9169180. Configure here.
There was a problem hiding this comment.
yes bestie it's on purpose
2 participants
Description
Adding a default "no_extras" pytest marks to our tests as a default, so we don't have to exclude each extra one by one in the testing module
Related Issue
Fixes #(issue number)
Type of Change
Testing
uv run pytest -m "cpu and not slow")For full setup and testing instructions, see the Contributing Guide.
Checklist
Thanks for contributing to Pruna! We're excited to review your work.
New to contributing? Check out our Contributing Guide for everything you need to get started.
First Prune (1-year OSS anniversary)
First Prune marks one year of Pruna’s open-source work. During the initiative window, qualifying merged contributions count toward First Prune. You can earn credits for our performance models via our API.
If you’d like your contribution to count toward First Prune, here’s how it works: