Open
Conversation
gsprochette
requested changes
Apr 30, 2026
Collaborator
gsprochette
left a comment
There was a problem hiding this comment.
I think the description here is still incomplete because it's missing the "how to add a new extra" part, and a "where to add an error to state that the extra should be installed to run this algorithm" part
| uv run pytest -m "cpu and not slow" | ||
| **Adding tests that need optional extras** |
Collaborator
There was a problem hiding this comment.
I both agree with this, but this is not really for adding whatever test that requires an already defined extra, it's really for adding a new extra, correct?
I think this could be completed into a How and when to add a new extra section that explains
- how and when to create an extra in the pyproject.toml
- where to add an error in the algorithm to state that the extra should be installed
- how to mark the test and add the extra to the CI
20f8c8d to
5cb6bee
Compare
gsprochette
approved these changes
Apr 30, 2026
Collaborator
gsprochette
left a comment
There was a problem hiding this comment.
Perfect, thanks for the changes 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#622 #653
Related Issue
Fixes #(issue number)
Type of Change
Testing
uv run pytest -m "cpu and not slow")For full setup and testing instructions, see the Contributing Guide.
Checklist
Thanks for contributing to Pruna! We're excited to review your work.
New to contributing? Check out our Contributing Guide for everything you need to get started.
First Prune (1-year OSS anniversary)
First Prune marks one year of Pruna’s open-source work. During the initiative window, qualifying merged contributions count toward First Prune. You can earn credits for our performance models via our API.
If you’d like your contribution to count toward First Prune, here’s how it works: