Skip to content

[1.21.1] Keeps editing .vscode/settings.json even though base settings are already there #152

Description

@VioletEverbloom

Modloader : Neoforge 21.1.218
Rhino version : 2107.2.7-build.81
KubeJS version : 2101.7.2-build.348
ProbeJS version : 7.7.2

Hi !
After the first dump, ProbeJS adds some settings to .vscode/settings.json. This is intended.
However, changing the mod environment and having ProbeJS do another dump causes it to edit .vscode/settings.json again, adding another identical json schema to it.

Initial settings :

{
    "typescript.tsserver.maxTsServerMemory": 4096,
    "typescript.disableAutomaticTypeAcquisition": true,
    "typescript.surveys.enabled": false,
    "typescript.validate.enable": false,
    "json.schemas": [
        {
            "fileMatch": [
                "/recipe_schema/*.json"
            ],
            "url": "./.vscode/recipe.json"
        }
    ]
}

Settings after another dump :

{
    "typescript.tsserver.maxTsServerMemory": 4096,
    "typescript.disableAutomaticTypeAcquisition": true,
    "typescript.surveys.enabled": false,
    "typescript.validate.enable": false,
    "json.schemas": [
        {
            "fileMatch": [
                "/recipe_schema/*.json"
            ],
            "url": "./.vscode/recipe.json"
        },
        {
            "fileMatch": [
                "/recipe_schema/*.json"
            ],
            "url": "./.vscode/recipe.json"
        }
    ]
}

This goes on and on every time the mod environment changes, ending up with a hundred lines long settings.json file, and it prevents me from tracking it with git for convenience.

Steps to reproduce :

  • Install a clean environment with Rhino, KubeJS and ProbeJS
  • Launch the game, start a new world and wait for the dump
  • Check the .vscode/settings.json file
  • Add any other mod
  • Again, launch the game, start a new world and wait for the dump
  • Check the changed .vscode/settings.json file

Since I didn't see an issue about it previously, it may have to do with my environment, so I'm available if you need further informations.

Thank you for your time !

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions