fix(build): run Xorg/desktop install on incremental builds too (start… - #675
Merged
Conversation
…x was never baked) `make image` calls `make(false)`, whose incremental path (taken whenever rootfs/<arch> already exists -- the common case, and one is even checked in) RETURNED before desktop::install / xorg::install. Those ran only on a from-scratch `clear` build, so an ordinary rebuild shipped an image with no X server: the freshly-built QEMU image booted to "sh: startx: not found". - Call desktop::install + xorg::install on the incremental path too (before its early return). apk-add of already-present packages is a no-op, so repeat builds stay cheap; desktop::install is idempotent config writes. - xorg::install now verifies the result and reports LOUDLY: on success it prints that the server/startx/libinput driver are present; on failure it prints a boxed, unmissable notice explaining that the image will say "startx: not found" and how to fix it (network to the mirror, or ECLIPSE_XORG_PACKAGES to match the repo's names). No more silent skip. xtask builds; fmt/clippy clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MHCn5RNRcwR5PY1sYBHY2S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…x was never baked)
make imagecallsmake(false), whose incremental path (taken whenever rootfs/ already exists -- the common case, and one is even checked in) RETURNED before desktop::install / xorg::install. Those ran only on a from-scratchclearbuild, so an ordinary rebuild shipped an image with no X server: the freshly-built QEMU image booted to "sh: startx: not found".xtask builds; fmt/clippy clean.
Claude-Session: https://claude.ai/code/session_01MHCn5RNRcwR5PY1sYBHY2S