Fix losing a item in ItemFrame upon interacting it on protected region you do not have access

[NightKLP]

this is the best thing i could come up with

• i tested it in my main server

• where spamming it doesn't dupe
• you do not lose your item modifier/prefix

• it is a common issue when players lose their item which cause by a itemframe
• if there's better ways than this i don't know honestly

[Arthri]

Thanks for the pull request! I have a few suggestions, if you don't mind

[lost-werewolf]

Why not just use the UpdateItemDrop (90) packet? In DropItemInstanced method from NPC.cs, the item slot is set to be unusable for 54000 frames after spawned, and then the item is set to inactive right after sending UpdateItemDrop. This eliminates sending a second packet afterwards and also replicates vanilla behavior for locally instanced items.
Of course, you need to send this packet to only the player who's being rejected.

[bartico6]

Why not just use the UpdateItemDrop (90) packet? In DropItemInstanced method from NPC.cs, the item slot is set to be unusable for 54000 frames after spawned, and then the item is set to inactive right after sending UpdateItemDrop. This eliminates sending a second packet afterwards and also replicates vanilla behavior for locally instanced items. Of course, you need to send this packet to only the player who's being rejected.

Repeatedly rightclicking a blocked item frame would fill up the locked out slots (54000 frames is 900 seconds or 15 minutes) and allow a malicious client to prevent item drops from functioning on the server at all by locking out all slots.

[lost-werewolf]

Why not just use the UpdateItemDrop (90) packet? In DropItemInstanced method from NPC.cs, the item slot is set to be unusable for 54000 frames after spawned, and then the item is set to inactive right after sending UpdateItemDrop. This eliminates sending a second packet afterwards and also replicates vanilla behavior for locally instanced items. Of course, you need to send this packet to only the player who's being rejected.

Repeatedly rightclicking a blocked item frame would fill up the locked out slots (54000 frames is 900 seconds or 15 minutes) and allow a malicious client to prevent item drops from functioning on the server at all by locking out all slots.

I see, thank you for the insight.
The unusable timer could perhaps be reduced to just a few seconds or even just one second with little to no impact on behavior as it is likely the client would pick up the item as soon as it's spawned on them. Not sure if this would be the best, as you said - a malicious client could indeed spam the item frame to temporarily disable item drops, but significantly reducing the timer could remedy this if it's set to something very low (perhaps just half a second - a second).

[hakusaro]

@Arthri @ACaiCat is this one okay to merge in your opinion?

[ACaiCat]

@Arthri @ACaiCat is this one okay to merge in your opinion?

Tested.It can work as intended.

[hakusaro]

Can someone update the wiki for this?