Skip to content

Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108

@kiki830621

Description

@kiki830621

Problem

Source: surfaced during /idd-plan #102 Step 2.5 tangential sweep (PR will be on branch idd/102-acceptance-review-doctrine once filed).
Tracks the consistency family that the #102 narrow scope deliberately does not unify.

#102 ships the NSQL Confirmation Protocol doctrine: verify-gated is the terminal default disposition — a clean 6/6 verify PASS is sufficient to merge; --review is an opt-in to re-open the confirmation loop, not a quality gate.

Per the doctrine, the user-facing PR-body checklist line currently reading - [ ] **Pending: human review of this PR + /idd-close after merge** should become - [x] **Verify-gated**: cluster/PR verify PASS — ready to merge by default, with --review flipping it to - [ ] **Pending: human acceptance review** (per --review flag).

#102 only updates this for idd-all-chain Phase 5 (line 553). Three sister files keep the old wording:

File Line Status
plugins/issue-driven-dev/skills/idd-implement/SKILL.md 503 OLD wording
plugins/issue-driven-dev/skills/idd-all/SKILL.md 746 OLD wording
plugins/issue-driven-dev/references/pr-flow.md 135 OLD wording

Result: post-#102, 4 PR-body templates that should all read the same now have a 1-vs-3 split. Doctrine is unified, surface is not.

Type

documentation (template family consistency)

Expected

After this issue ships, all 4 PR-body templates use the same doctrine-aligned wording — default = Verify-gated PASS — ready to merge, with --review opt-in flipping to Pending: human acceptance review (per --review flag).

idd-implement is special: it does not currently accept --review (the flag lives on idd-all and idd-all-chain). Decision for this issue:

  • Option A: only the default wording changes for idd-implement (the --review opt-in only meaningful when invoked via orchestrator).
  • Option B: idd-implement also accepts --review and threads it into PR body template. Slightly larger surface but symmetric.

Recommend Option A unless there's a need to invoke idd-implement directly with --review.

Actual

  • idd-all-chain Phase 5 PR body checklist: doctrine-aligned wording (conditional on --review).
  • idd-implement Step 5.5 PR body checklist: old wording (Pending: human review).
  • idd-all Phase 5 PR body checklist: old wording (Pending: human review).
  • references/pr-flow.md canonical: old wording (Pending: human review).

Impact

Notes

Not blocking #102 merge — the 1-vs-3 split is documented as a known follow-up in #102's Implementation Plan Out-of-scope section. Issue exists to make sure the cleanup actually happens.

Step 5.7 sister sweep update (added 2026-05-20 during /idd-implement #102)

A 4th file in the consistency family surfaced during the implementation sweep:

File Line Status
plugins/issue-driven-dev/references/chain-flow.md 254 OLD wording (Pending: human review of cluster PR)

chain-flow.md is the canonical contract reference for the chain shell algorithm — its PR body template should follow the same NSQL doctrine wording as the other 3 files. Scope of this issue updated 4-template → 5-template consistency family.

Source: surfaced during /idd-implement #102 Step 5.7 sweep (PR #109).

/idd-verify --pr 109 follow-up additions (added 2026-05-20)

The 6-AI verify of PR #109 (which ships the #102 doctrine that motivates this issue) surfaced additional consistency items worth grouping into this same family follow-up rather than opening separate issues:

F3 — idd-all-chain Phase 4 final report stdout text

  • Source: regression review (LOW); also surfaced by Devil's Advocate adversarial angle 2 ("messaging-only" claim audit)
  • Where: plugins/issue-driven-dev/skills/idd-all-chain/SKILL.md Phase 4 final report block (the forest-tree printout + STOP message rendered to the chain orchestrator's terminal, distinct from the PR-body checklist that [enhancement] acceptance-review 缺在 IDD mode model — 「人不 review」需要 first-class 做法 #102 PR [enhancement] acceptance-review 缺在 IDD mode model — 「人不 review」需要 first-class 做法 #109 already made --review-aware in commit dc61ffb)
  • What: Phase 4's stdout report (forest tree + "STOP — ..." message) is currently not conditional on $REVIEW_FLAG. It still emits the same text under both default and --review invocations. PR-body is the audit artifact and is fixed; stdout is for the human watching the chain run.
  • Action: dispatch Phase 4 final-report text on $REVIEW_FLAG the same way Phase 6 of /idd-all does (verify-gated PASS across cluster, ready to merge default vs verify-gated PASS — awaiting human acceptance (per --review) variant)

Req cosmetic — stale Trace 1 example block in idd-all/SKILL.md

  • Source: requirements review (LOW cosmetic)
  • Where: plugins/issue-driven-dev/skills/idd-all/SKILL.md around lines 893-901 (Trace 1 example documentation block)
  • What: example block still demonstrates the pre-v2.65 Verify: PASS + Next: review PR, merge wording. Functional Phase 6 report logic was swapped in 1fdcba0, but the example narrative in the doc was not updated to match.
  • Action: refresh Trace 1 example to show the new Verify: verify-gated PASS + Next: merge default + --review variant

DA3 — "messaging-only" wording precision

  • Source: Devil's Advocate review (INFO)
  • Where: idd-all + idd-all-chain Phase 0 args parsing comments (both files), and MANIFESTO Human-in-the-loop section
  • What: The phrase "messaging-only" is true at the orchestrator scope (the flag doesn't change skill execution or make the orchestrator wait), but humans + CI parsers downstream can react to the changed text differently — so it isn't messaging-only in the strict end-to-end sense.
  • Action: optional refinement to "orchestrator-scope messaging-only" or similar tightening — purely a clarity improvement, not a behavior fix

Updated scope of this issue

Originally: 4-template PR-body checklist wording sync.
After Step 5.7: 5-template (added chain-flow.md:254).
After this PR #109 verify: 5-template + 3 satellite follow-ups (F3 / Trace 1 example / DA3 wording) — all share the theme "NSQL doctrine consistency across the IDD documentation family".

(DA2 from PR #109 verify — logic reviewer's bash analysis process improvement — is intentionally NOT added here. It's a process observation about the verify reviewer pool itself, not a code fix.)

Current Status

Phase: diagnosed
Last updated: 2026-05-20 by idd-diagnose

Key Decisions

  • Complexity = Plan (Layer V: V≤3, untriggered)
  • Strategy: 5 PR-body wording sync + 3 satellite items (F3 / Trace 1 / DA3) = 8 edit sites across 6 files
  • Plan-tier triggers: 2+ files sequence dependency, decision-heavy (Option A vs B + version bump strategy + Trace 1 rewrite scope), cross-file refactor without external contract change
  • Sister concerns: none surfaced
  • Residue: deeper Spectra-tier question — should PR-body fragment be factored into shared template? (out of Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108 scope)

Scope Changes

  • (none — diagnosed scope matches issue body)

Blocking

Commits

  • (none yet)

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions