[enhancement] acceptance-review 缺在 IDD mode model — 「人不 review」需要 first-class 做法

[kiki830621]

Refs #102

Summary

Ships the MANIFESTO doctrine + --review flag that came out of /spectra-discuss #102. Three sequenced changes implement the conclusion:

1. MANIFESTO doctrine — new section ## Human-in-the-loop: IDD 即 NSQL Confirmation Protocol between the verification/closure-axes discussion and the TDD/SDD special-case section. Names the structural fact that IDD's human-in-the-loop is an NSQL Confirmation Protocol instance: human's confirmation loop closes before execution (at issue + idd-diagnose); idd-verify is execution-fidelity, not a confirmation loop; verify-gated is the named, sanctioned terminal default disposition; --review re-opens the confirmation loop (opt-in, NOT a quality gate); auto-merge legitimate but not the idd-all default — autopilot mechanics belong to feature: /idd-all (無參數) bulk-solve mode — AI 自動 sequence + bundle 所有 open issue #37.

2. idd-all --review flag + Phase 6 wording — new --review flag parses to $REVIEW_FLAG. Phase 6 PR-mode + direct-commit-mode reports dispatch on the flag:

   • default: Verify: verify-gated PASS + Next: merge, then /idd-close
   • --review: Verify: verify-gated PASS — awaiting human acceptance (re-opened confirmation loop per --review) + Next: review PR, merge after acceptance, then /idd-close

   Drops the legacy Pending: human review framing that implied a default second gate. 鐵律 永遠不 auto-merge PR unchanged — the doctrine permits; the default does not perform.

3. idd-all-chain --review propagation + PR body conditional — Phase 0 args parsing recognizes --review. Phase 2 chain loop appends $REVIEW_FLAG to each /idd-all #M --in-chain invocation (via ${REVIEW_FLAG:+ $REVIEW_FLAG} for safe whitespace handling). Cluster PR body checklist dispatches:

   • default: - [x] Verify-gated: per-issue verify PASS — cluster ready to merge
   • --review: - [ ] Pending: human acceptance review of cluster PR (per --review flag)

Plugin bumped to v2.65.0.

Out-of-scope (deliberate)

• idd-implement Step 5.5 / idd-all Phase 5 / pr-flow.md canonical PR-body checklist wording — filed as Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108 (4-template consistency follow-up). Discuss conclusion's narrow scope kept --review to the orchestrators only; Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108 syncs the rest post-merge.
• pr-flow.md mode resolution algorithm — --review is per-invocation, NOT a third axis. pr-flow.md untouched.
• Autopilot auto-merge mechanics — feature: /idd-all (無參數) bulk-solve mode — AI 自動 sequence + bundle 所有 open issue #37 territory. This PR ships the doctrine that lets feature: /idd-all (無參數) bulk-solve mode — AI 自動 sequence + bundle 所有 open issue #37 land later.
• Standing acceptance_policy config field — deferred per Discuss Conclusion.
• README.md — handled at /idd-close Step 6.5 via /plugin-tools:plugin-update Phase 2.5 (per IDD human-in-the-loop should conform to the NSQL confirmation protocol (v4.1.0) #103 precedent db25514).

Checklist

• Diagnose ✓ (Diagnosis — Complexity initially Spectra)
• Discuss ✓ (Conclusion — re-routed Spectra → Plan)
• Plan ✓ (Implementation Plan — EnterPlanMode approved 2026-05-20)
• Implement (4 commits, +123/−12 across 5 files)
• Verify (run /idd-verify --pr )
• Pending: human review of this PR + /idd-close after merge

---

Generated by /idd-implement on PR path. Do NOT add a GitHub close trailer (Closes/Fixes/Resolves) — IDD discipline requires manual /idd-close after merge to enforce checklist gate + closing summary.

[kiki830621]

Verify Report — PR #109

Engine

5 general-purpose Agents (Claude reviewers, file-based output) + Codex (gpt-5.5 xhigh, run_in_background) → 6-AI ensemble

Aggregate

CONDITIONAL PASS → fixed in-PR → effectively PASS — 1 HIGH blocking (F1) caught by 3 of 6 reviewers (regression / DA / Codex convergent), fixed in commit dc61ffb (also picked up DA1 + F2 polish in same commit). Mergeable as-is.

Scope coverage

PR Refs #102. Other #N mentions in PR body (#103 / #108 / #37) are prose context. Verified scope: #102 only.

Pre-merge gates

• Step 0.7 PR↔issue correspondence ✓ (Refs #102 at line 1 of PR body)
• Step 0.8 auto-close trap ✓ both sources clean (closingIssuesReferences empty + per-commit headline/body regex 0 hits across 4aef425 / 1fdcba0 / 11a99e0 / 8a41ee7 / dc61ffb)

---

#102 — IDD acceptance-review doctrine + --review flag

Requirements coverage: 3/3 deliverables FULLY addressed post-fix (1 PARTIALLY → FULLY after dc61ffb).

Deliverable	Status	Evidence
1. MANIFESTO new section (Human-in-the-loop / NSQL Confirmation Protocol)	FULLY	MANIFESTO.md:95-135 — mapping table + verify-gated terminal default + verify-as-review reframe + --review semantics + auto-merge clarification + (post-fix) /loop external-caller clarification. 4aef425 + dc61ffb
2. idd-all + idd-all-chain Phase 6/4 messaging swap	FULLY (post-fix)	idd-all/SKILL.md:778-843 (Phase 6 PR+direct-commit reports dispatch on $REVIEW_FLAG). idd-all-chain/SKILL.md:561-578 (PR-body checklist conditional, now mutex-correct after dc61ffb). Section heading renamed ## Pending review → ## Review status. 1fdcba0 + 11a99e0 + dc61ffb
3. --review per-invocation flag	FULLY	Both skills' Phase 0 args parsers + argument-hints + Step 0 bootstrap parse_review_flag tasks. idd-all-chain Phase 2 chain loop propagates via ${REVIEW_FLAG:+ $REVIEW_FLAG} to sub-/idd-all --in-chain. Orthogonal (no mutex) with --pr/--no-pr/--in-chain/--bfs/--cwd. 1fdcba0 + 11a99e0

Scope compliance ✓: out-of-scope items intact —

• idd-implement Step 5.5 + idd-all Phase 5 + references/pr-flow.md + references/chain-flow.md PR-body checklist wording untouched → tracked in Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108 (5-template family follow-up, scope extended during Step 5.7)
• Autopilot auto-merge mechanics → feature: /idd-all (無參數) bulk-solve mode — AI 自動 sequence + bundle 所有 open issue #37 territory
• references/pr-flow.md mode resolution algorithm → --review is not a third axis
• idd-verify / idd-implement / idd-close skill internals untouched — doctrine interprets, doesn't change them
• README.md → deferred to /idd-close Step 6.5 / /plugin-tools:plugin-update Phase 2.5 (per IDD human-in-the-loop should conform to the NSQL confirmation protocol (v4.1.0) #103 precedent db25514)
• Standing acceptance_policy config field → deferred per Discuss Conclusion

Findings

#	Severity	Action	Source	Description	Status
F1	HIGH	In-PR fix	agents:regression+devils-advocate+codex (3 sources convergent)	idd-all-chain/SKILL.md:566 used ${REVIEW_FLAG:+A}${REVIEW_FLAG:-B} thinking it was a mutex. ${var:-word} returns $var when set, NOT the alternative branch. Under --review, line rendered with stray --review literal appended (empirically reproduced: ... after merge--review).	FIXED in dc61ffb — explicit if/else builds $REVIEW_CHECKLIST_LINE before the heredoc; empirically validated both branches mutually exclusive
DA1	LOW	In-PR fix	agents:devils-advocate	MANIFESTO doctrine could be misread by /loop / ralph-loop / external CI callers as authorizing gh pr merge after Phase 6 verify-gated PASS report. Doctrine sanctions verify-gated as terminal state, NOT as auto-merge authorization.	FIXED in dc61ffb — MANIFESTO doctrine extended with explicit /loop / external-CI clarification: state declaration ≠ merge authorization; autopilot remains #37 territory
F2	LOW	In-PR fix	agents:regression	CHANGELOG Notes section listed 4-template scope for #108, but Step 5.7 sister sweep already extended it to 5-template (added chain-flow.md:254). Notes drifted.	FIXED in dc61ffb — CHANGELOG Notes section now lists chain-flow.md as the 4th file + adds parenthetical explaining the 4→5 scope expansion
F3	LOW	Follow-up	agents:regression	idd-all-chain Phase 4 final stdout text (forest tree + STOP message) is not --review-aware. PR-body checklist is (post-fix).	Defer — terminal output cosmetic, PR-body is the audit artifact
DA2	INFO	Process note	agents:devils-advocate	Logic reviewer's claim "bash-correct mutex" was an analysis error (didn't empirically test the ${VAR:-word} semantics). Process improvement: complex bash idioms should be empirically reproduced, not eyeballed.	Defer — process observation only, no code change
DA3	INFO	Follow-up	agents:devils-advocate	--review "messaging-only" claim is true at the orchestrator scope but downstream (humans, CI parsers) can react to the text differently. Refining language to "orchestrator-scope messaging-only" might be tighter.	Defer — wording refinement, not regression-blocking
LOW (cosmetic)	LOW	Defer	agents:requirements	3 cosmetic observations: stale Trace 1 example block in idd-all (lines 893-901) still shows old Verify: PASS wording; argument-hint length growing; future-robustness note on single-source REVIEW_FLAG parsing.	Defer — examples/hints stale but not user-visible-broken; can address in a doc polish pass alongside #108

Process Gaps

(none — all 5 Claude reviewer Agents + Codex produced findings files first attempt, no Step 2.5 Recovery Protocol fires)

Self-referentiality check (DA adversarial angle 1)

Doctrine self-referentiality (PR adds doctrine that verify-gated PASS is sufficient terminal, ships via 6-AI verify whose PASS would itself be the sanctioned disposition) — DA dismissed as blocker because:

1. The discuss conclusion (commit 4aef425 references it) is external grounding — the doctrine isn't bootstrapped from this PR's verify alone.
2. NSQL (kiki830621/NSQL) is an independent external reference protocol that IDD conforms to, not invents.
3. The 6-AI ensemble's adversarial design (Devil's Advocate + Codex cross-model) is itself the falsifiable check the doctrine names — convergent F1 catch demonstrates the design works.

Next

• F1 + DA1 + F2 already fixed in dc61ffb (committed + pushed). PR [enhancement] acceptance-review 缺在 IDD mode model — 「人不 review」需要 first-class 做法 #109 now ready for merge.
• F3 / DA2 / DA3 / cosmetic findings → Step 5b triage (most defer; some land in Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108 or new follow-up).
• After polish triage: PR [enhancement] acceptance-review 缺在 IDD mode model — 「人不 review」需要 first-class 做法 #109 ready for merge → /idd-close #102.

Reports referenced

• Requirements: PASS (3 cosmetic obs)
• Logic: PASS (analysis error on F1, but 6 other checks correct)
• Security: PASS (0 findings)
• Regression: CONDITIONAL → PASS (F1 fixed)
• Devil's Advocate: CONDITIONAL → PASS (F1 + DA1 fixed)
• Codex: PARTIALLY → PASS (F1 fixed; concurred on chain-flow drift now in Sync 4-template PR-body checklist wording to match #102 NSQL doctrine #108)