[Docker Doctor] Support space-separated ENV KEY VALUE format in secret detection#7
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support space-separated ENV KEY VALUE format in secret detection
Environment variables (
ENV) in Dockerfiles can be specified asENV KEY=VALUEorENV KEY VALUE. Currently, theno-secrets-in-envcheck assumesKEY=VALUEformat, leaving space-separated credentials undetected. This PR adds support for parsing the space-separated format so that hardcoded passwords and secrets inENVare correctly caught by the linter.Changes
packages/core/src/rules/security.ts: Update thenoSecretsInEnvrule to detect if the instruction args contain=. If not, parse them asENV KEY VALUEand check the value for credentials.packages/core/test/rules.test.ts: Add unit tests verifying both space-separated secrets are detected and space-separated normal variables are ignored.