chore(web): add doctor.config.ts for verified non-issues - #28
Merged
PunGrumpy merged 1 commit intoAug 7, 2026
Merged
Conversation
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
PunGrumpy
force-pushed
the
motion/08-doctor-config
branch
from
August 7, 2026 16:50
33429ed to
20e9eef
Compare
Two react-doctor rules fire on deliberate, verified-correct patterns: - no-create-object-url-without-revoke on lib/compress/api.ts, lib/compress/browser.ts, lib/image/ingest.ts: the analyzer is single-file, but these URLs are revoked cross-file by runJob (replace/stale) and revokeJobUrls (remove/clear-all/unmount). - no-fetch-in-effect on components/status.tsx: a one-shot client-side health probe that must run from the user's browser. Suppressing per-file keeps both rules active everywhere else. react-doctor now reports 100/100 with no issues. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PunGrumpy
force-pushed
the
motion/08-doctor-config
branch
from
August 7, 2026 16:57
20e9eef to
0935fce
Compare
PunGrumpy
added a commit
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the real fixes, two react-doctor rules still fired on patterns that are deliberate and verified correct, keeping the score below 100.
Root Cause
no-create-object-url-without-revoke(lib/compress/api.ts,lib/compress/browser.ts,lib/image/ingest.ts): the analyzer is single-file, but these URLs are lifecycle-managed cross-file —runJobrevokes the prior result URL on replace/stale runs, andrevokeJobUrls(lib/image/revoke.ts) revokes original + result URLs on removal, clear-all, and unmount.no-fetch-in-effect(components/status.tsx): a one-shot client-side health probe that must measure reachability from the user's browser, so it cannot move server-side or into an event handler.Solution
Adds
apps/web/doctor.config.tswith per-fileignore.overrides(rationale documented inline), keeping both rules active everywhere else in the codebase.Result
bun run doctorreports 100 / 100 — no issues found on the full stack.🤖 Generated with Claude Code