Skip to content

DevEx: phpc doctor --gates lists north-star2-verify steps (#1865 phase 2) #1871

@PurHur

Description

@PurHur

Problem

#1857 ✅ extended phpc doctor --gates with North Star 1 presenter steps (make north-star1-verify). #1865 adds make north-star2-verify for self-host M0–M4, but doctor output will not mention it until this follow-up lands — contributors still grep README for bootstrap commands.

Goal

Extend lib/Doctor.php runGates() with a North Star 2 presenter section:

Step Command LLVM?
Inventory php script/bootstrap-inventory.php --check no
Wave gate make bootstrap-wave-check partial
M0 link ./script/bootstrap-selfhost-link.sh yes
M2 spine BOOTSTRAP_LIB_SPINE_SMOKE=1 make bootstrap-selfhost-lib-spine-smoke yes
M2 VM smoke BOOTSTRAP_LIB_SPINE_VM_SMOKE=1 make bootstrap-selfhost-lib-spine-vm-smoke no
Presenter make north-star2-verify tail optional

Show spine count snapshot (584/588), whether BOOTSTRAP_M3_HELLOWORLD_STRICT is set, and LLVM probe (same as NS1).

Implementation hints

File Change
lib/Doctor.php printNorthStar2PresenterSection()
test/unit/PhpcDoctorTest.php or DoctorGatesTest.php Assert north-star2-verify substring
docs/GETTING-STARTED.md Cross-link #1865

Depends on #1865 landing script/north-star2-verify.sh first (or print “pending — see #1865” until then).

Acceptance criteria

./phpc doctor --gates | grep -i north-star2-verify
./script/ci-fast.sh --filter DoctorGates

Local/Docker only — not GitHub Actions (#394 ✅).

Dependencies

Links

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions