Skip to content

CI: SESSIONS_WEB_DEPLOY_SMOKE_GATE opt-in in ci-local after #1893 #1967

@PurHur

Description

@PurHur

Problem

#1891 ✅ landed two-request 005-SessionsWeb AOT execute (SessionsWebAotExecuteTest, examples-aot-smoke.sh with SESSIONS_WEB_AOT_SMOKE_GATE=1). 003 already has production-style deploy smoke via script/deploy-smoke.sh + make deploy-smoke (#718, #1530).

There is no env-gated hook in ci-local.sh for 005 deploy + PHPC_DEPLOY_ROOT CGI curls. Regressions in session file paths or cookie headers between phpc serve and deployed layout only show up when someone runs deploy smoke manually.

Goal

After #1893 implements deploy-smoke.sh --example 005 (or equivalent):

  1. Add SESSIONS_WEB_DEPLOY_SMOKE_GATE to script/ci-defaults.env (default 0)
  2. Call deploy smoke from script/ci-common.sh / script/ci-local.sh when gate =1 and LLVM ready
  3. Document in docs/local-ci-matrix.md, examples/005-SessionsWeb/README.md, and phpc doctor --gates (Testing: 005-SessionsWeb AOT link gate (#1946) #1964)

Follow-up (separate issue): default SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 after #1893 green on harness.

Scope

Piece Path Notes
Smoke impl #1893 script/deploy-smoke.sh --example 005, cookie jar, two CGI invocations
CI hook script/ci-common.sh Mirror ci_run_sessions_web_aot_smoke() pattern
Defaults script/ci-defaults.env SESSIONS_WEB_DEPLOY_SMOKE_GATE="${SESSIONS_WEB_DEPLOY_SMOKE_GATE:-0}"
Tests test/unit/CiScriptsTest.php Assert env var documented
Doctor lib/Doctor.php List gate + command (#1964)

Out of scope: implementing deploy curls (#1893); flipping default-on (follow-up after green).

Acceptance criteria

SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 ./script/ci-local.sh
# or:
SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 make deploy-smoke
  • Skips with exit 0 when LLVM 9 missing (same probe as other deploy smokes)
  • Failure cites which curl step broke (POST flash vs GET read)
  • No .github/workflows/* — verify on harness / Docker only

Verification (local / Docker only)

make docker-build-22
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  env SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 ./script/ci-local.sh

Dependencies

Links

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions