You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1891 ✅ landed two-request 005-SessionsWeb AOT execute (SessionsWebAotExecuteTest, examples-aot-smoke.sh with SESSIONS_WEB_AOT_SMOKE_GATE=1). 003 already has production-style deploy smoke via script/deploy-smoke.sh + make deploy-smoke (#718, #1530).
There is no env-gated hook in ci-local.sh for 005 deploy + PHPC_DEPLOY_ROOT CGI curls. Regressions in session file paths or cookie headers between phpc serve and deployed layout only show up when someone runs deploy smoke manually.
Goal
After #1893 implements deploy-smoke.sh --example 005 (or equivalent):
Add SESSIONS_WEB_DEPLOY_SMOKE_GATE to script/ci-defaults.env (default 0)
Call deploy smoke from script/ci-common.sh / script/ci-local.sh when gate =1 and LLVM ready
Problem
#1891 ✅ landed two-request 005-SessionsWeb AOT execute (
SessionsWebAotExecuteTest,examples-aot-smoke.shwithSESSIONS_WEB_AOT_SMOKE_GATE=1). 003 already has production-style deploy smoke viascript/deploy-smoke.sh+make deploy-smoke(#718, #1530).There is no env-gated hook in
ci-local.shfor 005 deploy +PHPC_DEPLOY_ROOTCGI curls. Regressions in session file paths or cookie headers betweenphpc serveand deployed layout only show up when someone runs deploy smoke manually.Goal
After #1893 implements
deploy-smoke.sh --example 005(or equivalent):SESSIONS_WEB_DEPLOY_SMOKE_GATEtoscript/ci-defaults.env(default0)script/ci-common.sh/script/ci-local.shwhen gate=1and LLVM readydocs/local-ci-matrix.md,examples/005-SessionsWeb/README.md, andphpc doctor --gates(Testing: 005-SessionsWeb AOT link gate (#1946) #1964)Follow-up (separate issue): default
SESSIONS_WEB_DEPLOY_SMOKE_GATE=1after #1893 green on harness.Scope
script/deploy-smoke.sh--example 005, cookie jar, two CGI invocationsscript/ci-common.shci_run_sessions_web_aot_smoke()patternscript/ci-defaults.envSESSIONS_WEB_DEPLOY_SMOKE_GATE="${SESSIONS_WEB_DEPLOY_SMOKE_GATE:-0}"test/unit/CiScriptsTest.phplib/Doctor.phpOut of scope: implementing deploy curls (#1893); flipping default-on (follow-up after green).
Acceptance criteria
SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 ./script/ci-local.sh # or: SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 make deploy-smoke.github/workflows/*— verify on harness / Docker onlyVerification (local / Docker only)
make docker-build-22 docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \ env SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 ./script/ci-local.shDependencies
phpc deployLinks