Skip to content

CI: Default SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 in ci-local after #1967 green #1974

@PurHur

Description

@PurHur

Problem

#1893 ✅ added 005-SessionsWeb deploy + PHPC_DEPLOY_ROOT CGI flash to script/deploy-smoke.sh. #1967 wires opt-in SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 into ci-local.sh (default still 0 in script/ci-defaults.env).

VM session smoke is already default-on (SESSIONS_WEB_SMOKE_GATE=1, #1894 ✅). Deploy regressions for session file paths / Set-Cookie under dist layout only surface when contributors remember the opt-in flag.

Goal

Flip SESSIONS_WEB_DEPLOY_SMOKE_GATE default from 01 in script/ci-defaults.env once #1967 opt-in path is green on harness + Docker for several batches.

Implementation hints

Piece Path Notes
Default script/ci-defaults.env SESSIONS_WEB_DEPLOY_SMOKE_GATE="${...:-1}"
CI hook script/ci-common.sh ci_run_deploy_smoke already gated
Makefile Makefile deploy-smoke target Runs 005 when gate=1
Docs docs/local-ci-matrix.md Row default 1
Tests test/unit/CiScriptsTest.php Assert new default string
Doctor lib/Doctor.php ✅ row when gate=1 (#1969)

Precedent: #1923 flips SESSIONS_WEB_AOT_SMOKE_GATE after #1921.

Acceptance criteria

  • ./script/ci-local.sh runs 005 deploy smoke without extra env on LLVM harness
  • SESSIONS_WEB_DEPLOY_SMOKE_GATE=0 ./script/ci-local.sh skips 005 deploy only
  • test/unit/DeploySmokeScriptTest.php green

Verification (local / Docker only)

make docker-build-22
./script/docker-ci-local.sh   # full gate with new default
SESSIONS_WEB_DEPLOY_SMOKE_GATE=0 ./script/ci-local.sh   # skip 005 deploy slice

No GitHub Actions (#394 ✅).

Dependencies

Links

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions