Problem
#1893 ✅ added 005-SessionsWeb deploy + PHPC_DEPLOY_ROOT CGI flash to script/deploy-smoke.sh. #1967 wires opt-in SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 into ci-local.sh (default still 0 in script/ci-defaults.env).
VM session smoke is already default-on (SESSIONS_WEB_SMOKE_GATE=1, #1894 ✅). Deploy regressions for session file paths / Set-Cookie under dist layout only surface when contributors remember the opt-in flag.
Goal
Flip SESSIONS_WEB_DEPLOY_SMOKE_GATE default from 0 → 1 in script/ci-defaults.env once #1967 opt-in path is green on harness + Docker for several batches.
Implementation hints
| Piece |
Path |
Notes |
| Default |
script/ci-defaults.env |
SESSIONS_WEB_DEPLOY_SMOKE_GATE="${...:-1}" |
| CI hook |
script/ci-common.sh |
ci_run_deploy_smoke already gated |
| Makefile |
Makefile deploy-smoke target |
Runs 005 when gate=1 |
| Docs |
docs/local-ci-matrix.md |
Row default 1 |
| Tests |
test/unit/CiScriptsTest.php |
Assert new default string |
| Doctor |
lib/Doctor.php |
✅ row when gate=1 (#1969) |
Precedent: #1923 flips SESSIONS_WEB_AOT_SMOKE_GATE after #1921.
Acceptance criteria
Verification (local / Docker only)
make docker-build-22
./script/docker-ci-local.sh # full gate with new default
SESSIONS_WEB_DEPLOY_SMOKE_GATE=0 ./script/ci-local.sh # skip 005 deploy slice
No GitHub Actions (#394 ✅).
Dependencies
Links
Problem
#1893 ✅ added 005-SessionsWeb deploy +
PHPC_DEPLOY_ROOTCGI flash toscript/deploy-smoke.sh. #1967 wires opt-inSESSIONS_WEB_DEPLOY_SMOKE_GATE=1intoci-local.sh(default still0inscript/ci-defaults.env).VM session smoke is already default-on (
SESSIONS_WEB_SMOKE_GATE=1, #1894 ✅). Deploy regressions for session file paths /Set-Cookieunder dist layout only surface when contributors remember the opt-in flag.Goal
Flip
SESSIONS_WEB_DEPLOY_SMOKE_GATEdefault from0→1inscript/ci-defaults.envonce #1967 opt-in path is green on harness + Docker for several batches.Implementation hints
script/ci-defaults.envSESSIONS_WEB_DEPLOY_SMOKE_GATE="${...:-1}"script/ci-common.shci_run_deploy_smokealready gatedMakefiledeploy-smoketargetdocs/local-ci-matrix.md1test/unit/CiScriptsTest.phplib/Doctor.phpPrecedent: #1923 flips
SESSIONS_WEB_AOT_SMOKE_GATEafter #1921.Acceptance criteria
./script/ci-local.shruns 005 deploy smoke without extra env on LLVM harnessSESSIONS_WEB_DEPLOY_SMOKE_GATE=0 ./script/ci-local.shskips 005 deploy onlytest/unit/DeploySmokeScriptTest.phpgreenVerification (local / Docker only)
No GitHub Actions (#394 ✅).
Dependencies
Links