Skip to content

php-in-php: ArrayDiffRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492) #23116

Description

@PurHur

Category

php-in-php · runtime-shrink (#1492, peer #22954 ArrayMerge / #22801 ArrayPush)

Problem

lib/JIT/Builtin/ArrayDiffRuntime.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for ArrayDiffJitHelper.php. Peer array runtimes (ArrayMergeRuntime #22954) route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

php-src reference

PHP implementation target

  • lib/JIT/Builtin/ArrayDiffRuntime.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled + lookupCompiled; drop use PHPCompiler\JIT / NestedJitCompileScope
  • test/unit/ArrayDiffRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/ArrayDiffRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

  • ArrayDiffRuntime uses JitVmHelperLink::ensureCompiled only for helper compile
  • Shrink unit test green
  • make bootstrap-selfhost-vm-driver-execute-probe green
  • PR body cites lines removed

Refs #1492, #12527, #14342, #22954, #22801

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:compilerCompiler / CFG / JITenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions