Skip to content

Trust: DomCompareDocumentPosition spine gap + 27 stale helper-runtime — user_release_ready=no (re-#25887/#25892) #25899

Description

@PurHur

Category

Foundation · Pillar 1 trust / spine-coverage + helper-runtime freshness (re-#25887 / re-#25892 / #24302)

Problem

./script/release-readiness.sh --json reports user_release_ready: no on master:

Gate Status Symptom
check-selfhost-spine-coverage-sync fail missing ext/dom/DomCompareDocumentPositionJitHelper.php, lib/JIT/Call/DomNodeCompareDocumentPosition.php
north-star5-verify --fast fail fails at spine-coverage step
check-helper-runtime-prelink.php --strict fail 27 stale units (dom + class introspection helpers)
inventory / cold-build / vm-driver-probe ok OK 6647/6647; cold-build ok; probe ok

#25878 landed DomNodeCompareDocumentPosition / DomCompareDocumentPositionJitHelper but they were never added to test/selfhost/compiler_lib_spine_smoke/main.php. Helper-runtime fingerprints drifted after recent dom/introspection edits; cold checkouts skip stale units and re-emit live.

Repro

php script/check-selfhost-spine-coverage-sync.php
# actual: FAILED — 2 inventory files missing from spine
php script/check-helper-runtime-prelink.php --strict
# actual: 307 fresh, 27 stale, 0 broken
./script/release-readiness.sh --json
# user_release_ready: no

PHP implementation target

  • test/selfhost/compiler_lib_spine_smoke/main.phprequire_once for the two DomCompareDocumentPosition paths (via ./script/spine-sync.sh --no-link)
  • prelinked/helper-runtime/x86_64-linux/ — re-emit stale units via php script/emit-helper-runtime-object.php --prelink (not fingerprint restamp)

Done when

  • php script/check-selfhost-spine-coverage-sync.php OK
  • php script/check-helper-runtime-prelink.php --strict → 0 stale
  • make north-star5-verify-fast green (spine + related steps)
  • release-readiness user_release_ready: yes (absent unrelated failures)
  • No fingerprint restamp; real spine requires + real unit re-emit

Refs #25878, #25887, #25892, #24302, #1922, #1945

Metadata

Metadata

Assignees

No one assigned

    Labels

    IMPORTANTCritical patharea:toolingTooling / CI / docsbugSomething isn't workingimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevExreleaseUser-facing release trackingrelease-blockerBlocks tagged user release

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions