Skip to content

CI: finish the truthful-master work — remove || true in ci-memory-env.sh, split setup from verdict steps, cache the dev image, delete the "GitHub Actions is disabled" claims, enable branch protection (re-#36209) #36247

Description

@PurHur

Category

Foundation: · CI truthfulness · child of #36188 · respin of #36209 (closed by PR #36233, which re-diffed the structgep patch, added --verify-pristine for two patches, and removed one || true in ci-common.sh)

Problem — what is still open from #36209

PHP implementation target

Steps 3–5 of #36209 verbatim: remove the || true; named Setup / Verdict steps with a setup-failed summary marker; GHCR-cached php-compiler:22.04-dev rebuilt only on Dockerfile diff; docs rewritten to describe the four workflows; branch protection requiring Compiler gate once it is green for 24 h.

Done when

  • Deleting a vendor patch makes ci-fast.sh exit non-zero within 30 s
  • gh run view --log-failed names Setup vs AOT smoke; median gate run ≥ 60 s faster
  • grep -ri "actions.*disabled" .cursor README.md CONTRIBUTING.md = 0; branches/master/protection requires Compiler gate

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    IMPORTANTCritical patharea:toolingTooling / CI / docsbugSomething isn't workingimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions