JIT: string-key nested array dim lowering for __hashtable__* (#1072)#1089
Merged
Conversation
…1072) Array literals like ['outer' => ['inner' => 42]] store nested hashtables via setAtStringKey; wire TYPE_HASHTABLE to __hashtable__setStringKeyHashtable so chained $a['outer']['inner'] compiles and runs in bootstrap AOT. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/1072-nested-array-dim
branch
from
6bc224a to
779313e
Compare
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_HASHTABLEhandling inHashTableHelper::setAtStringKey()so nested array literals like['outer' => ['inner' => 42]]store child hashtables via__hashtable__setStringKeyHashtable.nested_array_dim.phpcompile failure and enables chained$a['outer']['inner']reads in AOT.Test plan
php bin/compile.php -o build/bootstrap-aot/nested_array_dim test/bootstrap-aot/nested_array_dim.php42)Closes #1072
Made with Cursor