JIT: string-key nested array dim lowering + write path (#1072)#1092
Merged
Conversation
Wire writable string-key assignments through __hashtable__setStringKeyLong/Bool so chained $a['outer']['inner'] = … persists, and add bootstrap AOT coverage for mixed scalar leaves and nested writes. Closes #1072 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashTableHelper::setAtStringKey()lacked aTYPE_HASHTABLEarm, so array literals like['outer' => ['inner' => 42]]failed JIT withString-key array element type not supported for JIT: __hashtable__*(merged via JIT: string-key nested array dim lowering for __hashtable__* (#1072) #1089).JIT::assignOperand()routed$arr['key'] = <long|bool>through__value__writeLong/writeBoolon a scratch value-box instead of__hashtable__setStringKeyLong/setStringKeyBool, so chained nested writes were no-ops.nested_array_dim_mixed.php(long/string/bool leaves) andnested_array_dim_write.php(chained assignment) to bootstrap AOT link matrix.Closes #1072
Related: #1056, #1086 (bootstrap AOT link matrix recovery)
Test plan
PHP_COMPILER_LLVM_PATH=$PWD/.llvm make bootstrap-aot-link—nested_array_dim.php,nested_array_dim_mixed.php,nested_array_dim_write.phpOKtest/compliance/cases/language/nested_array_dim.phpt./script/bootstrap-aot-link.sh --verbosespot-check nested fixturesMade with Cursor