Skip to content

Fix DOM spine coverage for north-star5 fast gate (Closes #14484)#14491

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-14484-dom-spine-coverage-lane-b
Jul 1, 2026
Merged

Fix DOM spine coverage for north-star5 fast gate (Closes #14484)#14491
PurHur merged 1 commit into
masterfrom
agent/issue-14484-dom-spine-coverage-lane-b

Conversation

@PurHur

@PurHur PurHur commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add require_once for three ext/dom/ inventory files missing from compiler_lib_spine_smoke: DomClassConstants.php, NodeCompareDocumentPosition.php, NodeHasAttributes.php
  • Regenerate docs/bootstrap-inventory.md construct-flag notes for new DOM methods

Closes #14484

Verification

php script/check-selfhost-spine-coverage-sync.php
# check-selfhost-spine-coverage-sync: OK (spine covers all 3585 inventory files)

php script/bootstrap-inventory.php --check
# OK 3585/3585

make north-star5-verify-fast
# north-star5-verify: OK (fast — use --strict before merging bootstrap/M5 work)

./script/release-readiness.sh --json
# quick gates 5/5 green (spine-coverage-sync, inventory, north-star5-fast, vm-driver-probe, root-readme-sync)

Context

north-star5-verify-fast step 2 failed after recent ext/dom landings (#14478) left three inventory paths uncovered by the M2 spine bundle.

Made with Cursor

Add require_once entries for DomClassConstants, NodeCompareDocumentPosition,
and NodeHasAttributes so compiler_lib_spine_smoke covers all Phase A inventory
files after recent ext/dom landings.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release v1.1.0: spine — add ext/dom/NodeHasAttributes.php to compiler_lib_spine_smoke

1 participant