CI: default MINIWEBAPP_WEB_SMOKE_AOT_GATE=1 (#1523, #1752)#1836
Merged
PurHur merged 1 commit intoMay 25, 2026
Conversation
This was referenced May 25, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MINIWEBAPP_WEB_SMOKE_AOT_GATEto default-on inscript/ci-defaults.envand wireci_run_miniwebapp_web_smoke_aotintoci-local.shafter AOT prebuild.phpc doctor --gates/miniwebapp-gates.shstage 3c ladder, docs, and PHPUnit wiring tests.ensure_miniwebapp_aot_binarybuild status echo polluting command substitution when the 003 binary is built inline.Closes #1523. Implements #1752 doctor sync. Advances #1760 / North Star 1 (#1044) gate-flip bundle (
DEPLOY_SMOKE_003_EXECUTE=1was already default-on via #1530).Test plan
./script/docker-ci-local.sh --filter "CiScriptsTest|MiniWebAppUnskipMatrixTest|PhpcDoctorTest|MiniWebAppGatesScriptTest"— 12 tests OKMINIWEBAPP_WEB_SMOKE_AOT_GATE=1 ./script/examples-web-smoke.sh --miniwebapp-only --aot— home + hello PATH_INFO + contact POST greenMINIWEBAPP_WEB_SMOKE_GATE=0 ./script/ci-local.shLLVM tail — prebuild, 003 AOT web-smoke, deploy-smoke 003 execute greenMINIWEBAPP_WEB_SMOKE_AOT_GATE=0 ./script/ci-local.shMade with Cursor