Fix AOT link: restore parse_str delimited LLVM for multipart refresh (#1492)#18548
Merged
Merged
Conversation
…1492) #18449 restored StringMultipartStandaloneLlvm which calls __phpc_parse_str_* subhelpers, but #18466 had removed ParseStrUserScriptDelimitedJit. Re-wire ensureSubhelpers in ParseStrRuntime::ensureUserScriptLinked so user-script multipart/superglobal refresh links at AOT build time. Verification: ./script/check-aot-build-smoke.sh php vendor/bin/phpunit --filter SuperglobalsBracketRuntimeStandaloneTest Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Jul 13, 2026
PurHur
added a commit
that referenced
this pull request
Jul 13, 2026
…untime PHP (#18643) (#18645) #18548 restored ~1052 LOC hand-LLVM delimited parse subhelpers for StringMultipartStandaloneLlvm; #18615 routes multipart through MultipartNativeJitHelper + ParseStrNativeJitHelper PHP instead. Verification: - php vendor/bin/phpunit test/unit/ParseStrRuntimeShrinkTest.php → OK (13) - php vendor/bin/phpunit test/unit/SuperglobalRefreshRuntimeShrinkTest.php → OK - php vendor/bin/phpunit test/unit/JIT/SuperglobalsBracketRuntimeStandaloneTest.php → OK - php script/check-selfhost-spine-coverage-sync.php → OK - make bootstrap-selfhost-vm-driver-execute-probe → OK Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-fast/check-aot-build-smokefailed with undefined__phpc_parse_str_parse_delimited_pairs/__phpc_parse_str_ensure_childat link time.StringMultipartStandaloneLlvm(multipart$_FILESpopulate) which calls those symbols, but php-in-php: delete ParseStrUserScriptDelimitedJit — user-script AOT via ParseStrNativeJitHelper (#14217) #18466 had deletedParseStrUserScriptDelimitedJitthat implements them.ParseStrUserScriptDelimitedJit::ensureSubhelpers()fromParseStrRuntime::ensureUserScriptLinked()so user-script superglobal/multipart refresh emits linkable LLVM bodies beforeStringMultipartStandaloneLlvmreferences them.Refs #1492 (bootstrap gate). Follow-up: narrow or PHP-route delimited parse again once multipart no longer needs hand-LLVM subhelpers (#14217).
Verification
Made with Cursor