Compiler: file_get_contents data:// inline concat + offset/length (#18613)#18622
Merged
Merged
Conversation
Hoisted Concat + ConstFetch preludes before file_get_contents() with trailing embedded offset/length literals were not collected as producers when only some call args were dead inline temps. Accept distinct hoisted temps with trailing embedded literals so the data:// path reaches the builtin instead of an empty path ValueError. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_get_contents()takes an inline string concat as arg 0 plus hoistedfalse/nullcontext args and embedded offset/length literals.callArgsAreDistinctInlineTemporaries()rejected calls with trailing embedded literal args, so the Concat prelude was never collected and arg 0 bound to a hoistedfalseConstFetch → empty pathValueError.lib/Compiler.php(hoistedCallArgsAreDistinctInlineTemporaries); no C runtime change.php-src reference
ext/standard/file.c—php_file_get_contents_exdata URI slice with offset/maxlenfile_get_contents('data://text/plain,'.$payload, false, null, 3, 4)→3456Verification
Closes #18613
Made with Cursor